From: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
To: git@vger.kernel.org
Cc: levraiphilippeblain@gmail.com
Subject: [PATCH] imap-send: parse default git config
Date: Wed, 25 Nov 2020 09:05:52 +0100 [thread overview]
Message-ID: <8a21b031-fbfd-81c2-1f91-eff8c03bafb7@suse.com> (raw)
In-Reply-To: <76d2be10-0c42-70f4-101c-ee15e3039821@gmail.com>
git imap-send does not parse the default git config settings and thus ignore
core.askpass value.
Fix it by calling git_config(git_default_config)
Reported-by: Philippe Blain <levraiphilippeblain@gmail.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
---
imap-send.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/imap-send.c b/imap-send.c
index 5764dd812ca7..790780b76da2 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1367,6 +1367,7 @@ static void git_imap_config(void)
git_config_get_int("imap.port", &server.port);
git_config_get_string("imap.tunnel", &server.tunnel);
git_config_get_string("imap.authmethod", &server.auth_method);
+ git_config(git_default_config, NULL);
}
static int append_msgs_to_imap(struct imap_server_conf *server,
--
2.29.2.366.gb291b0a62802
next prev parent reply other threads:[~2020-11-25 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:20 [BUG] git imap-send does not honor 'core.askpass' Philippe Blain
2020-11-25 8:05 ` Nicolas Morey-Chaisemartin [this message]
2020-11-25 8:31 ` [PATCH] imap-send: parse default git config Junio C Hamano
2020-11-25 8:43 ` Nicolas Morey-Chaisemartin
2020-11-25 19:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a21b031-fbfd-81c2-1f91-eff8c03bafb7@suse.com \
--to=nmoreychaisemartin@suse.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).