Bug report: git-stash doesn't return correct status code

["Vromen, Tomer" <tomer.vromen@intel.com>]

Hi all,

I often use this one-liner:

> git stash && git checkout -b new-feature-branch && git stash pop

This is useful when I realize that I want to open a new branch for my changes (that I haven't committed yet).
However, I might have forgotten to save my changes in the editor, so git-stash will give this error:

No local changes to save

Despite the error, the command returns status code 0, and so the branch is created and the stash is popped, which was not my intention.
I think that git-stash should return a non-zero status code if it didn't push a new stash.

git version: 2.8.4


Thank you,
Tomer Vromen

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.