From: Kevin Bracey <kevin@bracey.fi>
To: "Jeff King" <peff@peff.net>, "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: Weird revision walk behaviour
Date: Thu, 24 May 2018 21:54:37 +0300 [thread overview]
Message-ID: <88f96a35-6368-de24-60ed-ad015f16f127@bracey.fi> (raw)
In-Reply-To: <20180523173523.GB10299@sigill.intra.peff.net>
On 23/05/2018 20:35, Jeff King wrote:
> There's more discussion in the thread at:
>
> https://public-inbox.org/git/1366658602-12254-1-git-send-email-kevin@bracey.fi/
>
> I haven't absorbed it all yet, but I'm adding Junio to the cc.
Just to ack that I've seen the discussion, but I can't identify the
code's reasoning at the moment. My recollection is that I accepted while
coming up with the algorithm that it might err slightly on the side of
false positives in the display - there were some merge cases I was
unable to fully distinguish whether or not the merge had lost a change
it shouldn't have done, and if I was uncertain I'd rather show it than not.
The first commit was not originally intended to alter behaviour for
anything other than --full-history, but later in the chain there was
specific consideration into tracking the path to the specified "bottom"
commit. It may be that's part of what's happening here.
Kevin
next prev parent reply other threads:[~2018-05-24 19:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 17:10 Weird revision walk behaviour SZEDER Gábor
2018-05-23 17:32 ` Jeff King
2018-05-23 17:35 ` Jeff King
2018-05-24 18:54 ` Kevin Bracey [this message]
2018-05-24 20:26 ` Kevin Bracey
2018-05-27 17:37 ` Kevin Bracey
2018-05-28 22:06 ` SZEDER Gábor
2018-05-29 6:11 ` Kevin Bracey
2018-05-29 21:04 ` Jeff King
2018-05-30 8:20 ` Kevin Bracey
2018-05-31 5:43 ` Jeff King
2018-05-31 14:54 ` Kevin Bracey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f96a35-6368-de24-60ed-ad015f16f127@bracey.fi \
--to=kevin@bracey.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).