From: Derrick Stolee <derrickstolee@github.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org, stolee@gmail.com
Subject: Re: [PATCH] commit-reach: do not parse and iterate minima
Date: Fri, 25 Mar 2022 10:32:48 -0400 [thread overview]
Message-ID: <88e4259e-8e1d-14bb-407f-3177b883388e@github.com> (raw)
In-Reply-To: <YjzrZNQZ7cBIr+Kx@nand.local>
On 3/24/2022 6:06 PM, Taylor Blau wrote:
> This made me think of some of the difficulties we encountered back in
> ce16364e89 (commit.c: don't persist substituted parents when
> unshallowing, 2020-07-08), particularly:
>
> One way to fix this would be to reset the parsed object pool entirely
> (flushing the cache and thus preventing subsequent reads from modifying
> their parents) after unshallowing. That would produce a problem when
> callers have a now-stale reference to the old pool, and so this patch
> implements a different approach.
>
> if I can recall back to when that patch was written, I think the issue
> was that dumping the entire set of parsed objects caused us to have
> stale references in the commit-graph machinery.
>
> I'm not sure whether or not the same difficulties would be encountered
> here, though. The shallow stuff is so tricky to me...
The commit-graph is disabled in the presence of grafts, so this
_should_ be fine. I guess there are some issues if you are
transitioning not having grafts to having grafts (or vice-versa)
so that might be worth investigating.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-03-25 14:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 21:08 [PATCH] commit-reach: do not parse and iterate minima Jonathan Tan
2022-03-23 23:30 ` Junio C Hamano
2022-03-24 15:27 ` Derrick Stolee
2022-03-24 22:06 ` Taylor Blau
2022-03-25 14:32 ` Derrick Stolee [this message]
2022-03-24 22:15 ` Jonathan Tan
2022-03-24 12:05 ` Bagas Sanjaya
2022-03-24 22:19 ` Jonathan Tan
2022-03-24 15:29 ` Derrick Stolee
2022-03-24 22:21 ` Jonathan Tan
2022-06-02 23:11 ` [PATCH v2] commit,shallow: unparse commits if grafts changed Jonathan Tan
2022-06-03 9:30 ` Ævar Arnfjörð Bjarmason
2022-06-03 13:29 ` Derrick Stolee
2022-06-03 15:27 ` Jonathan Tan
2022-06-03 15:26 ` Jonathan Tan
2022-06-06 17:54 ` [PATCH v3] " Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e4259e-8e1d-14bb-407f-3177b883388e@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).