git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* git-rebase -i not escaping # at the beginning of the line
       [not found] <ce2236de-8670-4213-8474-52365f0397bc@z14g2000yqa.googlegroups.com>
@ 2009-06-03 10:47 ` Petr Baudis
  2009-06-03 10:53   ` Johannes Schindelin
       [not found]   ` <20090603104718.GA10035-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
  0 siblings, 2 replies; 4+ messages in thread
From: Petr Baudis @ 2009-06-03 10:47 UTC (permalink / raw)
  To: donnoman; +Cc: git-users, git

On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> Redmine automatically links those log messages to the ticket when we
> use this method.  It works well for git commit -m "#1234 story xyz"
> 
> However, when we use git rebase -i, all of the lines that include the
> # character get stripped out of the commit messages.
> 
> How can we escape these?

This definitely sounds like a bug, what git version are you using?

-- 
				Petr "Pasky" Baudis
The lyf so short, the craft so long to lerne. -- Chaucer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: git-rebase -i not escaping # at the beginning of the line
  2009-06-03 10:47 ` git-rebase -i not escaping # at the beginning of the line Petr Baudis
@ 2009-06-03 10:53   ` Johannes Schindelin
  2009-06-03 10:57     ` Petr Baudis
       [not found]   ` <20090603104718.GA10035-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
  1 sibling, 1 reply; 4+ messages in thread
From: Johannes Schindelin @ 2009-06-03 10:53 UTC (permalink / raw)
  To: Petr Baudis; +Cc: donnoman, git-users, git

Hi,

On Wed, 3 Jun 2009, Petr Baudis wrote:

> On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > Redmine automatically links those log messages to the ticket when we
> > use this method.  It works well for git commit -m "#1234 story xyz"
> > 
> > However, when we use git rebase -i, all of the lines that include the
> > # character get stripped out of the commit messages.
> > 
> > How can we escape these?
> 
> This definitely sounds like a bug, what git version are you using?

It is sort of a bug, in a very peculiar: try amending such a commit 
_interactively_.  It will not work.

The reason: you are not supposed to start any line in a commit message 
with a '#'.  I would actually have expected "git commit -m" to refuse such 
a line.

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: git-rebase -i not escaping # at the beginning of the line
  2009-06-03 10:53   ` Johannes Schindelin
@ 2009-06-03 10:57     ` Petr Baudis
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Baudis @ 2009-06-03 10:57 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: donnoman, git-users, git

  Hi,

On Wed, Jun 03, 2009 at 12:53:27PM +0200, Johannes Schindelin wrote:
> On Wed, 3 Jun 2009, Petr Baudis wrote:
> 
> > On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > > Redmine automatically links those log messages to the ticket when we
> > > use this method.  It works well for git commit -m "#1234 story xyz"
> > > 
> > > However, when we use git rebase -i, all of the lines that include the
> > > # character get stripped out of the commit messages.
> > > 
> > > How can we escape these?
> > 
> > This definitely sounds like a bug, what git version are you using?
> 
> It is sort of a bug, in a very peculiar: try amending such a commit 
> _interactively_.  It will not work.
> 
> The reason: you are not supposed to start any line in a commit message 
> with a '#'.  I would actually have expected "git commit -m" to refuse such 
> a line.

  the line can also come there during import from another VCS, through
email, or so... I think it's more reasonable to deal with them when
filling in the commit message to the editor than in all the other
places.

-- 
				Petr "Pasky" Baudis
The lyf so short, the craft so long to lerne. -- Chaucer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: git-rebase -i not escaping # at the beginning of the  line
       [not found]   ` <20090603104718.GA10035-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
@ 2009-06-03 11:18     ` Alberto Leal
  0 siblings, 0 replies; 4+ messages in thread
From: Alberto Leal @ 2009-06-03 11:18 UTC (permalink / raw)
  To: git-users-/JYPxA39Uh5TLH3MbocFFw
  Cc: donnoman-Re5JQEeQqe8AvxtiuMwx3w, git-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

I`ve been using this and never had any problem.


On Wed, Jun 3, 2009 at 7:47 AM, Petr Baudis <pasky-+ZI9xUNit7I@public.gmane.org> wrote:

>
> On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > Redmine automatically links those log messages to the ticket when we
> > use this method.  It works well for git commit -m "#1234 story xyz"
> >
> > However, when we use git rebase -i, all of the lines that include the
> > # character get stripped out of the commit messages.
> >
> > How can we escape these?
>
> This definitely sounds like a bug, what git version are you using?
>
> --
>                                Petr "Pasky" Baudis
> The lyf so short, the craft so long to lerne. -- Chaucer
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Git for human beings" group.
To post to this group, send email to git-users-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to git-users+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at http://groups.google.com/group/git-users?hl=en
-~----------~----~----~----~------~----~------~--~---


[-- Attachment #2: Type: text/html, Size: 1628 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-06-03 11:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <ce2236de-8670-4213-8474-52365f0397bc@z14g2000yqa.googlegroups.com>
2009-06-03 10:47 ` git-rebase -i not escaping # at the beginning of the line Petr Baudis
2009-06-03 10:53   ` Johannes Schindelin
2009-06-03 10:57     ` Petr Baudis
     [not found]   ` <20090603104718.GA10035-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
2009-06-03 11:18     ` Alberto Leal

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).