git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Julian Phillips <julian@quantumfyre.co.uk>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Jeff King <peff@peff.net>, Eric Raymond <esr@snark.thyrsus.com>,
	Junio C Hamano <gitster@pobox.com>, <git@vger.kernel.org>
Subject: Re: git status --porcelain is a mess that needs fixing
Date: Sat, 10 Apr 2010 16:50:59 +0100	[thread overview]
Message-ID: <8871c8959d3ea4cd71452400e4c60dd0@212.159.54.234> (raw)
In-Reply-To: <h2j2cfc40321004100756g15ad7f12jf37e500f924e7b96@mail.gmail.com>

On Sun, 11 Apr 2010 00:56:47 +1000, Jon Seymour <jon.seymour@gmail.com>
wrote:
> On Sat, Apr 10, 2010 at 11:35 PM, Julian Phillips
> <julian@quantumfyre.co.uk> wrote:
>> On Sat, 10 Apr 2010 00:09:59 -0400, Jeff King <peff@peff.net> wrote:
>>> Your parser is already broken if you are calling split, as the
filenames
>>> may contain spaces (and will be quoted in that case, and you need to
>>> unmangle). You should use "-z".
>>>
>>> You will probably then realize that the "-z" format looks like:
>>>
>>>   XY file1\0file2\0
>>>
>>> which still sucks. It would be more friendly as:
>>>
>>>   XY\0file1\0file2\0
>>>
>>> So you could split on "\0". But even with that, you can't just blindly
>>> split, as the column and record separators are the same, and you might
>>> have one or two filenames.
>>
>> Not true.  If the second form was used, then you _can_ split on \0.  It
>> will tokenise the data for you, and then you consume ether two or three
>> tokens depending on the status flags.  So it would make the parsing
>> simpler.  But to make it even easier, how about adding a -Z that makes
>> the
>> output format "XY\0file1\0[file2]\0" (i.e. always three tokens per
>> record,
>> with the third token being empty if there is no second filename)?
>>  Though
>> if future expandability was wanted you could end each record with \0\0
>> and
>> then parsing would be a two stages of split on \0\0 for records and
then
>> split on \0 for entries?
> 
> Surely that won't work - if file2 can be empty, \0[file2]\0 reduces to
> \0\0 which would be confused with the \0\0 proposed as a record
> separator.

Yes.  But they were alternative suggestions, so if using \0\0 as the
record marker you would omit the second filename when empty as is currently
done.

-- 
Julian

  reply	other threads:[~2010-04-10 15:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 18:46 git status --porcelain is a mess that needs fixing Eric Raymond
2010-04-09 20:30 ` Junio C Hamano
2010-04-10  4:09 ` Jeff King
2010-04-10  5:46   ` Jonathan Nieder
2010-04-10  5:51     ` Jonathan Nieder
2010-04-10  6:03       ` Jeff King
2010-04-10  6:12         ` Jonathan Nieder
2010-04-10  6:32           ` Jeff King
2010-04-10  5:59   ` Eric Raymond
2010-04-10  7:40   ` [PATCH 0/5] "status --ignored" Junio C Hamano
2010-04-10  7:40     ` [PATCH 1/5] wt-status: remove unused workdir_untracked field Junio C Hamano
2010-04-10  7:40     ` [PATCH 2/5] wt-status: plug memory leak while collecting untracked files Junio C Hamano
2010-04-10  7:40     ` [PATCH 3/5] wt-status: collect ignored files Junio C Hamano
2010-04-10  7:48       ` Jeff King
2010-04-10  7:40     ` [PATCH 4/5] wt-status: rename and restructure status-print-untracked Junio C Hamano
2010-04-10  7:40     ` [PATCH 5/5] status: --ignored option shows ignored files Junio C Hamano
2010-04-10  7:44     ` [PATCH 0/5] "status --ignored" Jeff King
2010-04-10  7:48       ` Junio C Hamano
2010-04-10  8:40         ` Jeff King
2010-04-10 14:41           ` Eric Raymond
2010-04-10 18:27           ` Junio C Hamano
2010-04-10 19:20             ` Jakub Narebski
2010-04-11 10:35             ` Jeff King
2010-04-10 13:35   ` git status --porcelain is a mess that needs fixing Julian Phillips
2010-04-10 14:43     ` Eric Raymond
2010-04-10 14:56     ` Jon Seymour
2010-04-10 15:50       ` Julian Phillips [this message]
2010-04-10 23:33         ` Jon Seymour
2010-04-10 19:25     ` [RFC/PATCH] status: Add a new NUL separated output format Julian Phillips
2010-04-10 19:50       ` Eric Raymond
2010-04-10 20:34         ` Julian Phillips
2010-04-10 21:12           ` Eric Raymond
2010-04-10 23:03             ` [RFC/PATCH] status: Add json " Julian Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8871c8959d3ea4cd71452400e4c60dd0@212.159.54.234 \
    --to=julian@quantumfyre.co.uk \
    --cc=esr@snark.thyrsus.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jon.seymour@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).