git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Adam Dinwoodie" <adam@dinwoodie.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Git v2.13.1 SHA1 very broken
Date: Tue, 6 Jun 2017 01:11:00 +0100	[thread overview]
Message-ID: <8847fce7-1961-0006-37b7-3f10f7ebf32f@ramsayjones.plus.com> (raw)
In-Reply-To: <15c976f0-9203-dbba-86b6-240e44a1a56f@ramsayjones.plus.com>



On 06/06/17 00:20, Ramsay Jones wrote:
> 
> 
> On 05/06/17 22:05, Ævar Arnfjörð Bjarmason wrote:
>> On Mon, Jun 5, 2017 at 10:34 PM, Adam Dinwoodie <adam@dinwoodie.org> wrote:
>>> I'm trying to compile Git v2.13.1 to release for Cygwin, but it appears
>>> a010391 ("sha1dc: update from upstream", 2017-05-20) is breaking a very
>>> significant number of test cases in both 32-bit and 64-bit Cygwin
>>> builds.
>>>
>>> The first failure is t0000.46 "validate object ID of a known tree"; output with
>>> -x and -v is below, although it's not very interesting:
>>>
>>>     expecting success:
>>>             test "$tree" = 7bb943559a305bdd6bdee2cef6e5df2413c3d30a
>>>
>>>     ++ test ceb282701536fe61bea01075664405caa7d6343f = 7bb943559a305bdd6bdee2cef6e5df2413c3d30a
>>>     + test_eval_ret_=1
>>>     + want_trace
>>>     + test t = t
>>>     + test t = t
>>>     + set +x
>>>     error: last command exited with $?=1
>>>     not ok 46 - validate object ID of a known tree
>>>     #
>>>     #               test "$tree" = 7bb943559a305bdd6bdee2cef6e5df2413c3d30a
>>>     #
>>>
>>> I have no idea where to even begin debugging this, but I'm happy to take
>>> pointers / try things out on my box.
>>
>> That looks scary, can you please comment out this:
>>
>>     #define SHA1DC_ALLOW_UNALIGNED_ACCESS
> 
> No, that doesn't fix it.
> 
>>
>> In sha1dc/sha1.c and see if that helps, alternatively comment out the
>> ifdefs guarded by "#ifdef _MSC_VER" calls in sha1dc/sha1.c
> 
> This can't possibly make a difference! ;-)
> 
> However, rebuilding with:
> 
>     $ make OPENSSL_SHA1=YesPlease >out2 2>&1
> 
> ... make t0000-basic.sh pass just fine, so ...

commit 7e71542e8b ("sha1dc: avoid CPP macro collisions", 25-03-2017)
runs t0000-basic.sh just fine.

commit a0103914c2 ("sha1dc: update from upstream", 20-05-2017) fails
when running t0000-basic.sh.

I will look into this more tomorrow (it is late, I need sleep), unless
someone finds the solution overnight, of course.

Adam, you can build using the OPENSSL_SHA1 build variable for now
(if you want to release v2.13.1), or wait for another maint release
I suppose, ... I'll leave that to you! ;-)

ATB,
Ramsay Jones



  reply	other threads:[~2017-06-06  0:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 20:34 Git v2.13.1 SHA1 very broken Adam Dinwoodie
2017-06-05 21:05 ` Ævar Arnfjörð Bjarmason
2017-06-05 23:20   ` Ramsay Jones
2017-06-06  0:11     ` Ramsay Jones [this message]
2017-06-06  1:20   ` Junio C Hamano
2017-06-06 10:03     ` Adam Dinwoodie
2017-06-06 11:55       ` Junio C Hamano
2017-06-06 12:43         ` Adam Dinwoodie
2017-06-06 14:47           ` Continous Integration (was: RE: Git v2.13.1 SHA1 very broken) Jason Pyeron
2017-06-06 15:04             ` Lars Schneider
2017-07-02 20:35               ` Adam Dinwoodie
2017-07-03 12:34                 ` Johannes Schindelin
2017-06-06 15:12           ` [PATCH 0/3] update sha1dc Ævar Arnfjörð Bjarmason
2017-06-06 15:12             ` [PATCH 1/3] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2017-06-06 15:12             ` [PATCH 2/3] sha1dc: optionally use sha1collisiondetection as a submodule Ævar Arnfjörð Bjarmason
2017-06-06 18:48               ` Stefan Beller
2017-06-06 19:03                 ` Ævar Arnfjörð Bjarmason
2017-06-06 19:09                   ` Stefan Beller
2017-06-06 15:12             ` [PATCH 3/3] sha1collisiondetection: automatically enable when submodule is populated Ævar Arnfjörð Bjarmason
2017-06-06 18:23             ` [PATCH 0/3] update sha1dc Stefan Beller
2017-06-06 18:51               ` Ævar Arnfjörð Bjarmason
2017-06-06 19:01                 ` [PATCH] sha1dc: ignore indent-with-non-tab whitespace violations Jeff King
2017-06-06 19:04                   ` Ævar Arnfjörð Bjarmason
2017-06-06 19:05                   ` Stefan Beller
2017-06-13  2:09             ` [PATCH 0/3] update sha1dc Liam R. Howlett
2017-06-06 12:49         ` Git v2.13.1 SHA1 very broken Morten Welinder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8847fce7-1961-0006-37b7-3f10f7ebf32f@ramsayjones.plus.com \
    --to=ramsay@ramsayjones.plus.com \
    --cc=adam@dinwoodie.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).