From: Andreas Amann <a.amann@ucc.ie>
To: Peter Krefting <peter@softwolves.pp.se>
Cc: Paul Mackerras <paulus@samba.org>, <git@vger.kernel.org>
Subject: Re: [PATCH] gitk: Add a "Save file as" menu item
Date: Sun, 21 Jul 2013 20:53:39 +0100 [thread overview]
Message-ID: <87zjtfhepo.fsf@msstf091.ucc.ie> (raw)
In-Reply-To: <alpine.DEB.2.00.1307211910250.9615@ds9.cixit.se>
Peter Krefting <peter@softwolves.pp.se> writes:
> Andreas Amann:
>
>> + set difffile "$diffidtext [file tail $flist_menu_file]"
>> + set difffile [tk_getSaveFile -initialfile $difffile -title "Save file as" -parent .]
>> + if {$difffile eq {}} {
>> + return
>> + }
>> + save_file_from_commit $diffid:$flist_menu_file $difffile "revision $diffid"
>
> I might be misunderstanding the code (this is not one of my preferred
> programming languages), but it looks like this is missing the gettext
> markers necessary to get these strings localized.
thanks for pointing this out. Will resend an updated patch.
next prev parent reply other threads:[~2013-07-21 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 12:38 [PATCH] gitk: Add a "Save file as" menu item Andreas Amann
2013-07-21 18:13 ` Peter Krefting
2013-07-21 19:53 ` Andreas Amann [this message]
2013-07-21 19:55 ` [PATCH v2] " Andreas Amann
2013-07-28 15:30 ` [PATCH v3] " Andreas Amann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjtfhepo.fsf@msstf091.ucc.ie \
--to=a.amann@ucc.ie \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peter@softwolves.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).