From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Chen Jingpiao <chenjingpiao@gmail.com>, git@vger.kernel.org
Subject: Re: [GSoC][PATCH] commit: add a commit.signOff config variable
Date: Sun, 04 Feb 2018 19:59:58 +0100 [thread overview]
Message-ID: <87zi4olgwh.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180204113135.GA28130@flurp.local>
On Sun, Feb 04 2018, Eric Sunshine jotted:
> --- >8 ---
> for cfg in true false
> do
> for opt in '' --signoff --no-signoff
> do
> case "$opt:$cfg" in
> --signoff:*|:true) expect= ;;
> --no-signoff:*|:false) expect=! ;;
> esac
> test_expect_success "commit.signoff=$cfg & ${opt:---signoff omitted}" '
> git -c commit.signoff=$cfg commit --allow-empty -m x $opt &&
> eval "$expect git log -1 --format=%B | grep ^Signed-off-by:"
> '
> done
> done
> --- >8 ---
>
> A final consideration is that tests run slowly on Windows, and although
> it's nice to be thorough by testing all six combinations, you can
> probably exercise the new code sufficiently by instead testing just two
> combinations. For instance, instead of all six combinations, test just
> these two:
>
> --- >8 ---
> test_expect_success 'commit.signoff=true & --signoff omitted' '
> git -c commit.signoff=true commit --allow-empty -m x &&
> git log -1 --format=%B | grep ^Signed-off-by:
> '
>
> test_expect_success 'commit.signoff=true & --no-signoff' '
> git -c commit.signoff=true commit --allow-empty -m x --no-signoff &&
> ! git log -1 --format=%B | grep ^Signed-off-by:
> '
> --- >8 ---
I just skimmed this, but just to this question. I don't think we need to
worry about 2 v.s. 6 tests having an impact on Windows performance, it's
just massive amounts of tests like my in-flight wildmatch test series
that really matter.
But if we are worring about 2 v.s. 6 there's always my in-flight
EXPENSIVE_ON_WINDOWS prereq :)
next prev parent reply other threads:[~2018-02-04 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 2:03 [GSoC][PATCH] commit: add a commit.signOff config variable Chen Jingpiao
2018-02-04 11:31 ` Eric Sunshine
2018-02-04 18:59 ` Ævar Arnfjörð Bjarmason [this message]
2018-02-05 21:50 ` Stefan Beller
2018-02-06 7:01 ` Chen Jingpiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi4olgwh.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=chenjingpiao@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).