From: Leah Neukirchen <leah@vuxu.org>
To: git@vger.kernel.org
Subject: [RFC PATCH] color: respect the $NO_COLOR convention
Date: Thu, 01 Mar 2018 17:44:20 +0100 [thread overview]
Message-ID: <87zi3reoez.fsf@gmail.com> (raw)
When the NO_COLOR environment variable is set to any value, default to
disabling color, i.e. resolve 'auto' to false.
NO_COLOR (http://no-color.org/) is a comprehensive approach to disable
colors by default for all tools:
> All command-line software which outputs text with ANSI color added
> should check for the presence of a NO_COLOR environment variable that,
> when present (regardless of its value), prevents the addition of ANSI
> color.
Signed-off-by: Leah Neukirchen <leah@vuxu.org>
---
This is a first stab at implementing NO_COLOR for git, effectively
making it then behave like before colors were enabled by default.
I feel this should be documented somewhere, but I'm not sure where the
best place is. Perhaps in config.ui, or the Git environment variables
(but they all start with GIT_).
color.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/color.c b/color.c
index d48dd947c..59e9c2459 100644
--- a/color.c
+++ b/color.c
@@ -326,6 +326,8 @@ int git_config_colorbool(const char *var, const char *value)
static int check_auto_color(void)
{
+ if (getenv("NO_COLOR"))
+ return 0;
if (color_stdout_is_tty < 0)
color_stdout_is_tty = isatty(1);
if (color_stdout_is_tty || (pager_in_use() && pager_use_color)) {
--
2.16.2
next reply other threads:[~2018-03-01 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:44 Leah Neukirchen [this message]
2018-03-01 17:10 ` [RFC PATCH] color: respect the $NO_COLOR convention Junio C Hamano
2018-03-01 17:23 ` Leah Neukirchen
2018-03-01 19:06 ` Junio C Hamano
2018-03-04 22:39 ` brian m. carlson
2018-03-05 2:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi3reoez.fsf@gmail.com \
--to=leah@vuxu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).