From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)
Date: Thu, 01 Jul 2021 15:06:37 +0200 [thread overview]
Message-ID: <87zgv6cgxs.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CAFQ2z_Opw4dZmH7Xc4tRzMvD-op-Reh3C7sM31VoNM5eAHaiLA@mail.gmail.com>
On Thu, Jul 01 2021, Han-Wen Nienhuys wrote:
> (now in plain text)
>
> On Thu, Jul 1, 2021 at 9:17 AM Han-Wen Nienhuys <hanwen@google.com> wrote:
>>> Futz with the way 'errno' is relied on in the refs API to carry the
>>> failure modes up the callchain.
>>>
>>> Will merge to 'next'?
>
> Is there anything I can do to address the '?' here?
>
> I am happy to do a review for a similar sized chunk of other code for
> someone else in exchange for review of this.
I took you up on that and gave that series a detailed look now[1].
I'm afraid what I had to say there doesn't bode well for getting it to
'next' (some style/questions etc. there, but also what I believe is a
serious bug in 8/8 was among the findings[2]).
I'd like you to take a look & review any of my outstanding "ab/*"
serieses (or combinatino thereof) of similar scope/complexity as yours
in return. I'l leave it to your interests & sense of fairness what to
pick which one(s) :)
1. https://lore.kernel.org/git/pull.1012.v2.git.git.1623329868.gitgitgadget@gmail.com/
2. https://lore.kernel.org/git/8735sydvzs.fsf@evledraar.gmail.com/
next prev parent reply other threads:[~2021-07-01 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 22:55 What's cooking in git.git (Jun 2021, #07; Wed, 30) Junio C Hamano
2021-07-01 0:02 ` Felipe Contreras
[not found] ` <CAFQ2z_PYJMzOBcN+KoQSfdD-eYtZVzrArL0Dh-YW-q3R8hgm2w@mail.gmail.com>
2021-07-01 7:19 ` Han-Wen Nienhuys
2021-07-01 13:06 ` Ævar Arnfjörð Bjarmason [this message]
2021-07-01 13:42 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:20 ` Jeff Hostetler
2021-07-01 14:00 ` Ævar Arnfjörð Bjarmason
2021-07-01 15:21 ` Junio C Hamano
2021-07-02 12:18 ` Ævar Arnfjörð Bjarmason
2021-07-02 16:05 ` Junio C Hamano
2021-07-01 16:51 ` Jeff King
2021-07-01 16:20 ` Jeff King
2021-07-03 5:04 ` Elijah Newren
2021-07-05 8:03 ` Ævar Arnfjörð Bjarmason
2021-07-05 12:02 ` Jeff King
2021-07-06 13:46 ` Phillip Wood
2021-07-06 19:29 ` Ævar Arnfjörð Bjarmason
2021-07-06 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgv6cgxs.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).