From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Rast Subject: Re: [PATCH 1/3] cherry-pick: add support to copy notes Date: Wed, 29 May 2013 10:40:17 +0200 Message-ID: <87y5ayqivi.fsf@linux-k42r.v.cablecom.net> References: <1369745947-19416-1-git-send-email-felipe.contreras@gmail.com> <1369745947-19416-2-git-send-email-felipe.contreras@gmail.com> <7vobbv119k.fsf@alter.siamese.dyndns.org> <87mwrfx9ug.fsf@linux-k42r.v.cablecom.net> <51a56bef1b9c2_807b33e1899991@nysa.mail> <877giixl4c.fsf@linux-k42r.v.cablecom.net> Mime-Version: 1.0 Content-Type: text/plain Cc: Junio C Hamano , , Jonathan Nieder , Ramkumar Ramachandra , "Christian Couder" To: Felipe Contreras X-From: git-owner@vger.kernel.org Wed May 29 10:40:36 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uhbvv-0001UZ-0d for gcvg-git-2@plane.gmane.org; Wed, 29 May 2013 10:40:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965091Ab3E2Ik2 (ORCPT ); Wed, 29 May 2013 04:40:28 -0400 Received: from edge10.ethz.ch ([82.130.75.186]:15540 "EHLO edge10.ethz.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965069Ab3E2IkY (ORCPT ); Wed, 29 May 2013 04:40:24 -0400 Received: from CAS22.d.ethz.ch (172.31.51.112) by edge10.ethz.ch (82.130.75.186) with Microsoft SMTP Server (TLS) id 14.2.298.4; Wed, 29 May 2013 10:40:17 +0200 Received: from linux-k42r.v.cablecom.net.ethz.ch (129.132.153.233) by CAS22.d.ethz.ch (172.31.51.112) with Microsoft SMTP Server (TLS) id 14.2.298.4; Wed, 29 May 2013 10:40:17 +0200 In-Reply-To: (Felipe Contreras's message of "Wed, 29 May 2013 03:19:12 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Originating-IP: [129.132.153.233] Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Felipe Contreras writes: > On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: >> Felipe Contreras writes: > >>> Feel free to implement that. I'm just interested in 'git cherry-pick' being >>> usable for 'git rebase' purposes. >> >> Which would have been obvious to all but the most casual readers, eh? > > My motivations are irrelevant, the patch is good as it is. You fooled both Junio (AFAICT anyway) and me, who both reviewed the patch under the assumption that it implements note copying *along the lines of existing note copying*. This proved to be a wrong, and time-wasting, assumption. I think all the points in this discussion have been made in the lengthy thread about remote-{bzr,hg} already. So much so in fact that your continuing defiance of the project standards, knowing that they will elicit exactly this response, amounts to trolling. So until this changes, my $0.02 is a blanket NAK and a refusal to spend my time reviewing. -- Thomas Rast trast@{inf,student}.ethz.ch