From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] gc: introduce an --auto-exit-code option for undoing 3029970275
Date: Wed, 10 Oct 2018 22:59:45 +0200 [thread overview]
Message-ID: <87tvltecvy.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20181010203531.GA12949@sigill.intra.peff.net>
On Wed, Oct 10 2018, Jeff King wrote:
> On Wed, Oct 10, 2018 at 07:27:32PM +0000, Ævar Arnfjörð Bjarmason wrote:
>
>> Add an --auto-exit-code variable and a corresponding 'gc.autoExitCode'
>> configuration option to optionally bring back the 'git gc --auto' exit
>> code behavior as it existed between 2.6.3..2.19.0 (inclusive).
>>
>> This was changed in 3029970275 ("gc: do not return error for prior
>> errors in daemonized mode", 2018-07-16). The motivation for that patch
>> was to appease 3rd party tools whose treatment of the 'git gc --auto'
>> exit code is different from that of git core where it has always been
>> ignored.
>
> OK. I wouldn't want to use this myself, but I think you've made clear
> why you find it useful. So I don't mind making it an optional behavior
> (and it probably beats you trying to poke at the logfile yourself).
[...]
> I'm not sure if the config is going to actually help that much, though.
> The callers within Git will generally ignore the exit code anyway. So
> for those cases, setting it will at best do nothing, and at worst it may
> confuse the few stragglers (e.g., the git-svn one under recent
> discussion).
Yeah git internals don't care, but we've never advertised the
combination of --auto and gc.autoDetach=true as being something
internal-only, so e.g. I wrote stuff expecting errors, and one might run
"git gc --auto" in a repo whose .git/objects state is uncertain to see
if it needed repack (and have a shell integration that reports
failures...).
> Callers who _are_ prepared to act on the exit code probably ought to
> just use --auto-exit-code in their invocation.
>
> That said, I'm not entirely opposed to the matching config. There's
> enough history here that somebody might want a sledgehammer setting to
> go back to the old behavior.
If it's not a config option then as git is upgraded I'll need to change
my across-server invocation to be some variant of checking git version,
then etiher using the --auto-exit-code option or not (which'll error on
older gits). Easier to be able to just drop in a config setting before
the upgrade.
next prev parent reply other threads:[~2018-10-10 20:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACPiFCJZ83sqE7Gaj2pa12APkBF5tau-C6t4_GrXBWDwcMnJHg@mail.gmail.com>
2018-10-09 22:51 ` git svn clone/fetch hits issues with gc --auto Martin Langhoff
2018-10-09 23:45 ` Eric Wong
2018-10-10 2:49 ` Junio C Hamano
2018-10-10 11:01 ` Martin Langhoff
2018-10-10 11:27 ` Ævar Arnfjörð Bjarmason
2018-10-10 11:41 ` Martin Langhoff
2018-10-10 11:48 ` Ævar Arnfjörð Bjarmason
2018-10-10 16:51 ` Jonathan Nieder
2018-10-10 17:46 ` Jeff King
2018-10-10 19:27 ` [PATCH] gc: introduce an --auto-exit-code option for undoing 3029970275 Ævar Arnfjörð Bjarmason
2018-10-10 20:35 ` Jeff King
2018-10-10 20:59 ` Ævar Arnfjörð Bjarmason [this message]
2018-10-11 0:38 ` Jeff King
2018-10-10 20:56 ` Jonathan Nieder
2018-10-10 21:05 ` Ævar Arnfjörð Bjarmason
2018-10-10 21:14 ` Jonathan Nieder
2018-10-10 21:36 ` Junio C Hamano
2018-10-10 21:51 ` Jonathan Nieder
2018-10-10 22:16 ` Ævar Arnfjörð Bjarmason
2018-10-10 22:25 ` Jonathan Nieder
2018-10-10 18:38 ` git svn clone/fetch hits issues with gc --auto Ævar Arnfjörð Bjarmason
2018-10-10 11:43 ` Ævar Arnfjörð Bjarmason
2018-10-10 12:21 ` Junio C Hamano
2018-10-10 12:37 ` Ævar Arnfjörð Bjarmason
2018-10-10 16:38 ` Martin Langhoff
2018-10-10 8:04 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvltecvy.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).