git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Luke Shumaker <lukeshu@lukeshu.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] extra: new concept of extra components
Date: Mon, 14 Jun 2021 16:18:30 +0200	[thread overview]
Message-ID: <87tum0zfub.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20210614043450.1047571-1-felipe.contreras@gmail.com>


On Sun, Jun 13 2021, Felipe Contreras wrote:

> This patch series introduces the concept of extra components. These are
> components which are not yet part of the core but are good enough for
> distributions to ship, and in fact, they already do.

I like this direction.

> The measuring stick I'm using to gauge if a component in contrib belongs
> in extra is simple: are we already running tests for them with
> 'make test'?

I have a CI failure in one series of mine that seems to be a lack of
updating to CMake in contrib/buildsystems, perhaps we should be adding
that to extra/ too, i.e. extending this to the "make test" run by CI?

Not something that should hinder or necessarily be included in this
series, just a note about a related component.

> And we might move some components from the core which aren't realy part
> of the core to extra, like gitk, git-gui, git-p4, and git-svn.

I'd also like to see us run the tests for the likes of mw-to-git,
diff-highlight and subtree by default, at least under CI or some
"extended tests" mode, even though we may not install them by default.

  parent reply	other threads:[~2021-06-14 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  4:34 [PATCH 0/2] extra: new concept of extra components Felipe Contreras
2021-06-14  4:34 ` [PATCH 1/2] completion: graduate out of contrib Felipe Contreras
2021-06-14 14:12   ` Ævar Arnfjörð Bjarmason
2021-06-16 20:09     ` Felipe Contreras
2021-06-14  4:34 ` [PATCH 2/2] git-new-workdir: " Felipe Contreras
2021-06-14 14:18 ` Ævar Arnfjörð Bjarmason [this message]
2021-06-16  0:40   ` [PATCH 0/2] extra: new concept of extra components Junio C Hamano
2021-06-16 20:48     ` Felipe Contreras
2021-06-16 20:28   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tum0zfub.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lukeshu@lukeshu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).