From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2] routines to generate JSON data
Date: Thu, 22 Mar 2018 09:38:34 +0100 [thread overview]
Message-ID: <87sh8sy06t.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180321192827.44330-1-git@jeffhostetler.com>
On Wed, Mar 21 2018, git@jeffhostetler.com wrote:
> So, I'm not sure we have a route to get UTF-8-clean data out of Git, and if
> we do it is beyond the scope of this patch series.
>
> So I think for our uses here, defining this as "JSON-like" is probably the
> best answer. We write the strings as we received them (from the file system,
> the index, or whatever). These strings are properly escaped WRT double
> quotes, backslashes, and control characters, so we shouldn't have an issue
> with decoders getting out of sync -- only with them rejecting non-UTF-8
> sequences.
>
> We could blindly \uXXXX encode each of the hi-bit characters, if that would
> help the parsers, but I don't want to do that right now.
>
> WRT binary data, I had not intended using this for binary data. And without
> knowing what kinds or quantity of binary data we might use it for, I'd like
> to ignore this for now.
I agree we should just ignore this problem for now given the immediate
use-case.
prev parent reply other threads:[~2018-03-22 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 19:28 [PATCH v2] routines to generate JSON data git
2018-03-21 19:28 ` [PATCH v2] json_writer: new routines to create data in JSON format git
2018-03-21 21:25 ` Junio C Hamano
2018-03-23 14:13 ` Jeff Hostetler
2018-03-23 18:01 ` René Scharfe
2018-03-23 19:55 ` Jeff Hostetler
2018-03-23 20:11 ` René Scharfe
2018-03-23 20:32 ` Jeff Hostetler
2018-03-22 6:05 ` [PATCH v2] routines to generate JSON data Jeff King
2018-03-22 8:38 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8sy06t.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).