git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: git@vger.kernel.org
Subject: push docs: inaccurate description of omitted destination?
Date: Sun, 12 May 2019 23:47:08 -0400	[thread overview]
Message-ID: <87sgtj6mo3.fsf@kyleam.com> (raw)

It seems to me that push's manpage contains a couple of inaccurate (or
at least confusingly incomplete) statements about omitting the
destination part of the refspec.

First, the refspec section of the manpage has this to say:

    If `git push [<repository>]` without any `<refspec>` argument is set to
    update some ref at the destination with `<src>` with
    `remote.<repository>.push` configuration variable, `:<dst>` part can
    be omitted--such a push will update a ref that `<src>` normally updates
    without any `<refspec>` on the command line.  Otherwise, missing
    `:<dst>` means to update the same ref as the `<src>`.

Reading that, I'd think that, if I haven't configured
remote.<repository>.push in a way that involves <src>, omitting <dst>
will update the remote ref with the same name.  But push.default is also
consulted before falling back entirely to using the remote ref with the
same name:

    $ git rev-parse --symbolic-full-name HEAD
    refs/heads/topic
    $ git rev-parse --symbolic-full-name @{upstream}
    refs/remotes/origin/master
    $ git -c push.default=upstream push -n origin topic ;# unmentioned case
    To ../rem
       09cc638..58f7f72  topic -> master

    $ git branch --unset-upstream topic
    $ git -c push.default=upstream push -n origin topic ;# fallback case
    To ../rem
     * [new branch]      topic -> topic

Second, the example section says

    `git push origin master`::
       Find a ref that matches `master` in the source repository
       (most likely, it would find `refs/heads/master`), and update
       the same ref (e.g. `refs/heads/master`) in `origin` repository
       with it.  If `master` did not exist remotely, it would be
       created.

Perhaps I'm misreading that, but I'd interpret that as saying the remote
ref with the same name will always be updated, but that doesn't match
the refspec description of an omitted destination shown above or the
push.default-dependent behavior demonstrated in the example above.

             reply	other threads:[~2019-05-13  3:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13  3:47 Kyle Meyer [this message]
2019-05-13  9:18 ` push docs: inaccurate description of omitted destination? Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgtj6mo3.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).