From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0C3761F5AE for ; Thu, 6 May 2021 20:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233892AbhEFUtc (ORCPT ); Thu, 6 May 2021 16:49:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233701AbhEFUt3 (ORCPT ); Thu, 6 May 2021 16:49:29 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6934FC061574 for ; Thu, 6 May 2021 13:48:30 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id o16so8825386ljp.3 for ; Thu, 06 May 2021 13:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eN9OBKMPhUvQBuSGi0kEN5DUt/w5lXTP+AHamoNxp6M=; b=Js6VVcqeKSvcbrXukME1OBkuG7eXPPAmhZKXPFl1xkAXLnKV2aniRy5QpQvmuuJmZa PAmrgFavw1PBZozJfnvbnar/1pCn7Ch/1vCiKliDk3J3FXgYg7NE8X6g8leUqbl1KRk/ SAY44rNXMkdm7thqIqHa2h8lv6xb682rZXarj5+uq4VyInGHKSON9L+ihPEF0hJPIxMz dndcz8tb3hJtNEyXIrVUMv2wIKrUnwnABwaMhGFX0u5LfFos3/ghtnWBSaUbhqsTKfZl /LUwLxcwQ38SHcvYk99Xy6h/d3HzAJNELF+KIjjc1fnA+5W7h2Gm4pc1cn+XjNxWEFnx VjKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eN9OBKMPhUvQBuSGi0kEN5DUt/w5lXTP+AHamoNxp6M=; b=je+ZZE3vWnfhsSNK5z58czxaazSdBMyhWPgbSmLspCTKAU4kvDVfkWYII6ANfloY+4 e7XkrYXec621t2y6muM+fHwxfAMvl/RAfB5aTgRYbxo8GYuFSs8m1PZCDTj4oWlLyT6B cySTuZdihrHG5o++dNHGUTrdlMRPfayyvCxZZALg2MLP80JQUeRwT92p9mM3e0b0TUiy eN+mehruGKheMQJ+BbUtPbPOqScVpMdTB8ymxV0ubrjW6JVC2boNU0kavek9N4BAIAjk tZaw9stZdXdvcAxDtHjq0moS10uI1y1ptPxE1keacD02P4fyeFoe8+iV5UHrZtqmaASp mC6A== X-Gm-Message-State: AOAM533OZ69iG+QmM4Mfl74AuLc9dE6c7M2ZphkaWUD7U1q0vfWNNqLO TyN0I3y/Vz3v6O8BODHT5/UMbL4DT18= X-Google-Smtp-Source: ABdhPJw1+jqN6O1+FgDh18VTHBzkHoeGlg60Yh8nsUexPQPNZ2OgsaLzmpQRnBplSOm1TqMGvz587A== X-Received: by 2002:a2e:9707:: with SMTP id r7mr5192576lji.181.1620334108735; Thu, 06 May 2021 13:48:28 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id u16sm1261379lja.48.2021.05.06.13.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 13:48:28 -0700 (PDT) From: Sergey Organov To: Junio C Hamano Cc: Alex Henrie , Git mailing list Subject: Re: Why doesn't `git log -m` imply `-p`? References: <87im45clkp.fsf@osv.gnss.ru> <87v9837tzm.fsf@osv.gnss.ru> <87czu7u32v.fsf@osv.gnss.ru> <87eeemhnj4.fsf@osv.gnss.ru> <87r1imbmzz.fsf@osv.gnss.ru> <87tunh9tye.fsf@osv.gnss.ru> <87wnscuif9.fsf@osv.gnss.ru> Date: Thu, 06 May 2021 23:48:27 +0300 In-Reply-To: (Junio C. Hamano's message of "Fri, 07 May 2021 05:29:32 +0900") Message-ID: <87sg2zr3l0.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: F> Sergey Organov writes: > >> It's nice we've reached mutual understanding! > > Yes, and thanks for correcting me. > >> The only remaining issue then is if we just go and do the change of -m >> semantics, or do we need to take some backward compatibility measures? >> Looks like we are rather safe to just go, as it's unlikely there will be >> any real breakage. What do you think? > > I still wish I could come up with the usual backward compatibility > transition dance for this case, but I do not think there is one. Fine, thanks, so I'll prepare and submit a patch. > > However. > > If "-m" were doing a more useful thing than "compare with each > parent separately", people may have aliased "log -m" to something so > that their "git aliased-log" and "git aliased-log -p" would work > better for them than "git log" and "git log -p", but quite honestly, > I do not think "git log -m -p" output is readable by humans (after > all, that is why we invented -c and --cc), so the population that > get hit by this incompatible change may be very tiny minority in > relative terms. Well, honestly, I can't even come up with an alias that would break by this change, but it's likely I'm just not creative enough :) Thanks, -- Sergey Organov