git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Yuri <yuri@rawbw.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [feature suggestion] Improve stash descriptions
Date: Mon, 26 Apr 2021 11:00:57 +0200	[thread overview]
Message-ID: <87r1ix4dsc.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <YIWkHBfb4g68Oxr3@camp.crustytoothpaste.net>


On Sun, Apr 25 2021, brian m. carlson wrote:

> [[PGP Signed Part:Undecided]]
> On 2021-04-23 at 21:16:38, Yuri wrote:
>> My current stash looks like this:
>> 
>> $ git stash list
>> stash@{0}: WIP on main: 12c63aaa3b13 www/yt-dlp: Update 2021.04.11 ->
>> 2021.04.22 Reported by: portscout
>> stash@{1}: WIP on main: 140f08246898 devel/py-PeachPy: Update g20180225 ->
>> 0.0.1
>> stash@{2}: WIP on main: d42e82e4a336 security/hs-cryptol: Update 2.10.0 ->
>> 2.11.0
>> stash@{3}: WIP on main: 62851ab415cd dns/subfinder: Update 2.4.6 -> 2.4.7
>> stash@{4}: WIP on main: 4eec712dfdae math/gretl: Correct PKGNAME to be
>> 2021a, not 2021.a to reflect how Gretl is versioned.
>> stash@{5}: WIP on main: 725e4e9a07f0 devel/py-fypp: Update 3.0 -> 3.1
>> stash@{6}: WIP on main: 200eb286c368 misc/py-orange3-educational: Update
>> 0.1.8 -> 0.4.0
>> stash@{7}: WIP on main: 364ab57861e2 misc/urh: Update 2.9.1 -> 2.9.2
>> stash@{8}: WIP on main: 52c6d02708d0 science/py-nilearn: Update 0.7.0 ->
>> 0.7.1
>> stash@{9}: WIP on main: a9d5d9e05bbf New port: biology/seqkit:
>> Cross-platform and ultrafast toolkit for FASTA/Q file manipulation
>> stash@{10}: WIP on main: ffa307fb4dc3 games/iqpuzzle: Update 1.2.2 -> 1.2.3
>> stash@{11}: WIP on main: 195f2e27fd72 math/py-libpoly: Update 0.1.8 -> 0.1.9
>> stash@{12}: WIP on main: 4c2cc95952a6 graphics/mesa-devel: update to
>> 21.0.b.4390
>> stash@{13}: WIP on main: 4c2cc95952a6 graphics/mesa-devel: update to
>> 21.0.b.4390
>> stash@{14}: On main: audio/tuxguitar -- .
>> stash@{15}: On main: math/[py-]python-igraph
>> 
>> None of the above descriptions are relevant to actual items, for example:
>> 
>> $ git stash show stash@{2}
>>  devel/google-perftools/Makefile                      |  2 +-
>>  devel/google-perftools/distinfo                      |  6 +++---
>>  devel/google-perftools/files/patch-Makefile.am       |  4 ++--
>>  devel/google-perftools/files/patch-src_stacktrace.cc | 11 +++++++++++
>>  devel/google-perftools/pkg-plist                     | 12 ++++++------
>>  5 files changed, 23 insertions(+), 12 deletions(-)
>> 
>> - description mentions cryptol but actual items are related to perftools.
>
> Right.  The format here is "WIP on BRANCH: REVISION DESCRIPTION", where
> REVISION and DESCRIPTION correspond to the latest commit on the branch.
>
> I agree that in many situations this is an unhelpful message, which is
> why git stash push takes a --message argument so you can specify a
> different message.  That, of course, does require that you use it, and
> I will admit that even I don't always do that, sometimes much to the
> dismay of later me.
>
>> In case all changes are grouped in one ditectory, like in my case, git
>> should append this directory name to description:
>> 
>> > stash@{2}: WIP on main: d42e82e4a336 security/hs-cryptol: Update 2.10.0 ->
>> 2.11.0, all changes are in devel/google-perftools
>> 
>> 
>> In many cases it is possible to do so.
>> 
>> In case many directories are affected it could say "changes are in
>> path1/dir1, path2/dir2, etc."
>
> This is unfortunately not going to be very efficient to compute in
> certain cases, such as with large working trees where there are many
> changes.  So while it would improve the automated stash message, it
> might also make stashing much slower on large repositories.

Just to add to this, there's already:

    git stash list [--stat|--numstat|--shortstat]

It seems to me that what's being requested here is not so much a
stash-specific feature, but some abbreviated "human readable" stat
format that could be used with any log-like command.

  reply	other threads:[~2021-04-26  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 21:16 [feature suggestion] Improve stash descriptions Yuri
2021-04-25 17:17 ` brian m. carlson
2021-04-26  9:00   ` Ævar Arnfjörð Bjarmason [this message]
2021-04-26 16:14     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1ix4dsc.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=yuri@rawbw.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).