git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* approximate_object_count_valid never set?
@ 2020-09-17  8:20 Rasmus Villemoes
  2020-09-17 11:58 ` Ævar Arnfjörð Bjarmason
  2020-09-17 12:53 ` Jeff King
  0 siblings, 2 replies; 6+ messages in thread
From: Rasmus Villemoes @ 2020-09-17  8:20 UTC (permalink / raw)
  To: Git Mailing List
  Cc: Jeff King, Stefan Beller, Nguyễn Thái Ngọc Duy

Hi,

While poking around the code, I noticed that it seems
->approximate_object_count_valid is never set to 1, and it never has
been, not even back when it was a global variable. So perhaps it can
just be removed and the logic depending on it simplified? Or am I
missing some preprocessor trickery.

Nobody seems to have noticed the lack of caching - and actually setting
it to 1 after the count has been computed might be a little dangerous
unless one takes care to invalidate the cache anywhere that might be
relevant.

Rasmus

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-17 18:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17  8:20 approximate_object_count_valid never set? Rasmus Villemoes
2020-09-17 11:58 ` Ævar Arnfjörð Bjarmason
2020-09-17 12:53 ` Jeff King
2020-09-17 16:47   ` [PATCH] packfile: actually set approximate_object_count_valid Jeff King
2020-09-17 16:53     ` Taylor Blau
2020-09-17 18:26     ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).