From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS53758 23.128.96.0/24
X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id AE0A81F5AE
	for <e@yhbt.net>; Mon, 26 Apr 2021 17:35:35 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235324AbhDZRgO (ORCPT <rfc822;e@yhbt.net>);
        Mon, 26 Apr 2021 13:36:14 -0400
Received: from mav.lukeshu.com ([104.207.138.63]:38984 "EHLO mav.lukeshu.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S234794AbhDZRgN (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 26 Apr 2021 13:36:13 -0400
Received: from lukeshu-dw-thinkpad (unknown [IPv6:2601:281:8200:26:4e34:88ff:fe48:5521])
        by mav.lukeshu.com (Postfix) with ESMTPSA id A23A980590;
        Mon, 26 Apr 2021 13:35:27 -0400 (EDT)
Date:   Mon, 26 Apr 2021 11:35:27 -0600
Message-ID: <87pmyh9cf4.wl-lukeshu@lukeshu.com>
From:   Luke Shumaker <lukeshu@lukeshu.com>
To:     Danny Lin <danny0838@gmail.com>
Cc:     Luke Shumaker <lukeshu@lukeshu.com>,
        git develop <git@vger.kernel.org>,
        Avery Pennarun <apenwarr@gmail.com>,
        Charles Bailey <cbailey32@bloomberg.net>,
        "David A . Greene" <greened@obbligato.org>,
        David Aguilar <davvid@gmail.com>,
        Jakub Suder <jakub.suder@gmail.com>,
        James Denholm <nod.helm@gmail.com>, Jeff King <peff@peff.net>,
        Jonathan Nieder <jrnieder@gmail.com>,
        Junio C Hamano <gitster@pobox.com>,
        =?UTF-8?B?Tmd1eeG7hW4g?= =?ISO-8859-1?Q?Th=E1i_?=
         =?UTF-8?B?Tmfhu41j?= Duy <pclouds@gmail.com>,
        Roger L Strain <roger.strain@swri.org>,
        Techlive Zheng <techlivezheng@gmail.com>,
        Luke Shumaker <lukeshu@datawire.io>,
        Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 30/30] subtree: be stricter about validating flags
In-Reply-To: <CAMbsUu7PQ+Ni-fhGa3Fbc3YTODETYaPYGLPW9jqGgo=TcdPaAA@mail.gmail.com>
References: <20210423194230.1388945-1-lukeshu@lukeshu.com>
        <20210423194230.1388945-31-lukeshu@lukeshu.com>
        <CAMbsUu7PQ+Ni-fhGa3Fbc3YTODETYaPYGLPW9jqGgo=TcdPaAA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

On Sat, 24 Apr 2021 20:55:17 -0600,
Danny Lin wrote:
> Thank you for the recent works, Luke.
> 
> I'd like to know if you are aware or working on the issue that branches
> before "git subtree add --squash" are pushed via "git subtree push",
> which has been reported by me at Tue, 16 Jul 2019 02:30:44 +0800, as I
> haven't seen an obvious fix about it in the recent patches in a quick
> glance.

I'm not sure if I was aware of it before, but I'll be sure to keep it
in mind when I'm updating my (yet to be submitted) fixes to the
'split' algorithm.

Thanks for the additional test-case!

-- 
Happy hacking,
~ Luke Shumaker