From: Andrea Monaco <andrea.monaco@autistici.org>
To: git@vger.kernel.org
Subject: Possibly wrong assignment in config.c
Date: Wed, 13 Oct 2021 19:05:26 +0200 [thread overview]
Message-ID: <87pms8rh2h.fsf@autistici.org> (raw)
Hello,
while building git I get the following warning:
config.c: In function 'git_config_copy_or_rename_section_in_file':
config.c:3358:17: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
3358 | output[0] = '\t';
| ~~~~~~~~~~^~~~~~
config.c:3264:7: note: at offset -1 to object 'buf' with size 1024 declared here
3264 | char buf[1024];
| ^~~
concerning these lines:
output -= 1;
output[0] = '\t';
Perhaps it has some merit. output is previously equal to an array
buf[1024], so the assignment apparently goes outside allocated memory.
Let me know,
Andrea Monaco
next reply other threads:[~2021-10-13 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:05 Andrea Monaco [this message]
2021-10-13 19:14 ` Possibly wrong assignment in config.c Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pms8rh2h.fsf@autistici.org \
--to=andrea.monaco@autistici.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).