From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION
Date: Thu, 17 Jan 2019 10:31:49 +0100 [thread overview]
Message-ID: <87o98f4ol6.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <cover.1547677183.git.jonathantanmy@google.com>
On Wed, Jan 16 2019, Jonathan Tan wrote:
> Ævar, are you planning to revive GIT_TEST_PROTOCOL_VERSION? I have
> updated the patchset in light of some new branches that have appeared.
>
> This is on master merged with:
> - jk/proto-v2-hidden-refs-fix
> - tg/t5570-drop-racy-test
> - js/protocol-advertise-multi
> - jt/upload-pack-deepen-relative-proto-v2
> - jt/fetch-pack-v2
I'm happy to have you pick that up as you've done here, especially since
you're actually working on v2 and I'm not, so you can more easily know
what it conflicts with etc. I just wanted to have it in one way or
another, i.e. be able to deploy v2 and assert that "next + custom
patches" doesn't break something for v2.
I think [CC: Junio] that we shouldn't be concerned about an addition of
GIT_TEST_PROTOCOL_VERSION patches in any form breaking the test suite
under GIT_TEST_PROTOCOL_VERSION=2, and just be concerned about the
default GIT_TEST_PROTOCOL_VERSION= case. I.e. if we have v2 patches
in-flight that break things no big deal, we can always circle back and
fix those things or annotate the tests.
next prev parent reply other threads:[~2019-01-17 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 22:42 [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION Jonathan Tan
2019-01-16 22:42 ` [WIP 1/8] tests: define GIT_TEST_PROTOCOL_VERSION Jonathan Tan
2019-01-16 22:42 ` [WIP 2/8] tests: always test fetch of unreachable with v0 Jonathan Tan
2019-01-16 22:42 ` [WIP 3/8] t5503: fix overspecification of trace expectation Jonathan Tan
2019-01-16 22:42 ` [WIP 4/8] t5512: compensate for v0 only sending HEAD symrefs Jonathan Tan
2019-01-16 22:42 ` [WIP 5/8] t5700: only run with protocol version 1 Jonathan Tan
2019-01-16 22:42 ` [WIP 6/8] tests: fix protocol version for overspecifications Jonathan Tan
2019-01-16 22:42 ` [WIP 7/8] t5552: compensate for v2 filtering ref adv Jonathan Tan
2019-01-16 22:42 ` [WIP 8/8] remote-curl: in v2, fill credentials if needed Jonathan Tan
2019-01-17 9:31 ` Ævar Arnfjörð Bjarmason [this message]
2019-01-17 18:37 ` [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION Jonathan Tan
2019-01-17 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o98f4ol6.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).