From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Anders Kaseorg <andersk@MIT.EDU>,
git@vger.kernel.org
Subject: Re: [PATCH v2 git-gui] git-gui--askpass: Do not hang on exit
Date: Mon, 16 Aug 2010 00:53:18 +0100 [thread overview]
Message-ID: <87mxsnh1qp.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <20100704212439.GA1765@burratino> (Jonathan Nieder's message of "Sun, 4 Jul 2010 16:24:39 -0500")
Jonathan Nieder <jrnieder@gmail.com> writes:
>Anders Kaseorg wrote:
>
>> When git-gui--askpass is manually copied from the source into
>> /usr/lib/git-core, though, it doesn’t particularly work; its window
>> just freezes after the password is typed.
>
>The problem seems to be the
>
> bind . <Destroy> {exit $::rc}
>
>line; apparently each exit causes the window to be destroyed again,
>resulting in git gui hanging.
>
>Reported-by: Anders Kaseorg <andersk@mit.edu>
>Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>---
> I wrote:
>
> > @@ -52,7 +52,9 @@ proc finish {} {
> >
> > set ::rc 0
> > puts $::answer
> > + bind . <Destroy> {}
> > destroy .
>
> but that does nothing to help the case when the destroy event
> comes from the window manager. Here’s a saner patch (sorry for
> the noise).
>
>diff --git a/git-gui--askpass b/git-gui--askpass
>index 12e117e..20b8799 100755
>--- a/git-gui--askpass
>+++ b/git-gui--askpass
>@@ -39,7 +39,10 @@ pack .b -side bottom -fill x -padx 10 -pady 10
> bind . <Visibility> {focus -force .e}
> bind . <Key-Return> finish
> bind . <Key-Escape> {destroy .}
>-bind . <Destroy> {exit $rc}
>+bind . <Destroy> {
>+ bind . <Destroy> {}
>+ exit $::rc
>+}
>
> proc finish {} {
> if {$::yesno} {
I'm not so keen to take this patch for git-gui. Exiting from bindings
isn't such great Tk style and I'd rather we used a vwait to explicitly
run the event loop and exit after terminating that. The following patch
does this. 'git-gui: change the termination checks to avoid potential hang'
I'm not certain of the conditions that produced the error this is
supposed to fix. I have not reproduced the hang so far on a linux system
using Tk 8.5. It would be good to get confirmation that my proposed
patch actually solves the issue reported.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
prev parent reply other threads:[~2010-08-15 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100704203342.6064.32250.reportbug@balanced-tree>
2010-07-04 21:21 ` [PATCH git-gui] git-gui--askpass: Do not hang on exit Jonathan Nieder
2010-07-04 21:24 ` [PATCH v2 " Jonathan Nieder
2010-08-14 23:21 ` [PATCH] git-gui: change the termination checks to avoid potential hang Pat Thoyts
2010-08-18 4:21 ` Jonathan Nieder
2010-08-18 22:48 ` Pat Thoyts
2010-08-15 23:53 ` Pat Thoyts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxsnh1qp.fsf@fox.patthoyts.tk \
--to=patthoyts@users.sourceforge.net \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).