From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 04/23] fsmonitor: introduce `core.useBuiltinFSMonitor` to call the daemon via IPC
Date: Tue, 27 Apr 2021 11:20:56 +0200 [thread overview]
Message-ID: <87mttkyrqq.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <f77457d0-925d-2ea1-4ad4-b3315532b37f@gmail.com>
On Mon, Apr 26 2021, Derrick Stolee wrote:
> On 4/1/21 11:40 AM, Johannes Schindelin via GitGitGadget wrote:> @@ -2515,6 +2515,11 @@ int git_config_get_max_percent_split_change(void)
>>
>> int repo_config_get_fsmonitor(struct repository *r)
>> {
>> + if (r->settings.use_builtin_fsmonitor > 0) {
>
> Don't forget to run prepare_repo_settings(r) first.
>
>> + core_fsmonitor = "(built-in daemon)";
>> + return 1;
>> + }
>> +
>
> I found this odd, assigning a string to core_fsmonitor that
> would definitely cause a problem trying to execute it as a
> hook. I wondered the need for it at all, but found that
> there are several places in the FS Monitor subsystem that use
> core_fsmonitor as if it was a boolean, indicating whether or
> not the feature is enabled at all.
>
> A cleaner way to handle this would be to hide the data behind
> a helper method, say "fsmonitor_enabled()" that could then
> check a value on the repository (or index) and store the hook
> value as a separate value that is only used by the hook-based
> implementation.
>
> It's probably a good idea to do that cleanup now, before we
> find on accident that we missed a gap and start trying to run
> this bogus string as a hook invocation.
>> -static int query_fsmonitor(int version, const char *last_update, struct strbuf *query_result)
>> +static int query_fsmonitor(int version, struct index_state *istate, struct strbuf *query_result)
>> {
>> + struct repository *r = istate->repo ? istate->repo : the_repository;
>> + const char *last_update = istate->fsmonitor_last_update;
>> struct child_process cp = CHILD_PROCESS_INIT;
>> int result;
>>
>> if (!core_fsmonitor)
>> return -1;
>
> Here is an example of it being used as a boolean.
>
>> + if (r->settings.use_builtin_fsmonitor > 0) {
>> +#ifdef HAVE_FSMONITOR_DAEMON_BACKEND
>> + return fsmonitor_ipc__send_query(last_update, query_result);
>> +#else
>> + /* Fake a trivial response. */
>> + warning(_("fsmonitor--daemon unavailable; falling back"));
>> + strbuf_add(query_result, "/", 2);
>> + return 0;
>> +#endif
>
> This seems like a case where the helper fsmonitor_ipc__is_supported()
> could be used instead of compile-time macros.
>
> (I think this is especially true when we consider the future of the
> feature on Linux and the possibility of the same compiled code needing
> to check run-time properties of the platform for compatibility.)
>
>> --- a/repo-settings.c
>> +++ b/repo-settings.c
>> @@ -58,6 +58,9 @@ void prepare_repo_settings(struct repository *r)
>> r->settings.core_multi_pack_index = value;
>> UPDATE_DEFAULT_BOOL(r->settings.core_multi_pack_index, 1);
>>
>> + if (!repo_config_get_bool(r, "core.usebuiltinfsmonitor", &value) && value)
>> + r->settings.use_builtin_fsmonitor = 1;
>> +
>
> Follows the patterns of repo settings. Good.
It follows the pattern, but as an aside the pattern seems bit odd. I see
it dates back to your 7211b9e7534 (repo-settings: consolidate some
config settings, 2019-08-13).
I.e. we memset() the whole thing to -1, then for most things do something like:
if (!repo_config_get_bool(r, "gc.writecommitgraph", &value))
r->settings.gc_write_commit_graph = value;
UPDATE_DEFAULT_BOOL(r->settings.gc_write_commit_graph, 1);
But could do:
if (repo_config_get_bool(r, "gc.writecommitgraph", &r->settings.gc_write_commit_graph))
r->settings.gc_write_commit_graph = 1;
No? I.e. the repo_config_get_bool() function already returns non-zero if
we don't find it in the config.
I see the UPDATE_DEFAULT_BOOL() macro has also drifted from "set thing
default boolean" to "set any default value".
next prev parent reply other threads:[~2021-04-27 9:57 UTC|newest]
Thread overview: 237+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:40 [PATCH 00/23] [RFC] Builtin FSMonitor Feature Jeff Hostetler via GitGitGadget
2021-04-01 15:40 ` [PATCH 01/23] fsmonitor--daemon: man page and documentation Jeff Hostetler via GitGitGadget
2021-04-26 14:13 ` Derrick Stolee
2021-04-28 13:54 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 02/23] fsmonitor-ipc: create client routines for git-fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-04-26 14:31 ` Derrick Stolee
2021-04-26 20:20 ` Eric Sunshine
2021-04-26 21:02 ` Derrick Stolee
2021-04-28 19:26 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 03/23] config: FSMonitor is repository-specific Johannes Schindelin via GitGitGadget
2021-04-01 15:40 ` [PATCH 04/23] fsmonitor: introduce `core.useBuiltinFSMonitor` to call the daemon via IPC Johannes Schindelin via GitGitGadget
2021-04-26 14:56 ` Derrick Stolee
2021-04-27 9:20 ` Ævar Arnfjörð Bjarmason [this message]
2021-04-27 12:42 ` Derrick Stolee
2021-04-28 7:59 ` Ævar Arnfjörð Bjarmason
2021-04-28 16:26 ` [PATCH] repo-settings.c: simplify the setup Ævar Arnfjörð Bjarmason
2021-04-28 19:09 ` Nesting topics within other threads (was: [PATCH] repo-settings.c: simplify the setup) Derrick Stolee
2021-04-28 23:01 ` Ævar Arnfjörð Bjarmason
2021-05-05 16:12 ` Johannes Schindelin
2021-04-29 5:12 ` Nesting topics within other threads Junio C Hamano
2021-04-29 12:14 ` Ævar Arnfjörð Bjarmason
2021-04-29 20:14 ` Jeff King
2021-04-30 0:07 ` Junio C Hamano
2021-04-30 14:23 ` [PATCH 04/23] fsmonitor: introduce `core.useBuiltinFSMonitor` to call the daemon via IPC Jeff Hostetler
2021-04-01 15:40 ` [PATCH 05/23] fsmonitor--daemon: add a built-in fsmonitor daemon Jeff Hostetler via GitGitGadget
2021-04-26 15:08 ` Derrick Stolee
2021-04-26 15:45 ` Derrick Stolee
2021-04-30 14:31 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 06/23] fsmonitor--daemon: implement client command options Jeff Hostetler via GitGitGadget
2021-04-26 15:12 ` Derrick Stolee
2021-04-30 14:33 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 07/23] fsmonitor-fs-listen-win32: stub in backend for Windows Jeff Hostetler via GitGitGadget
2021-04-26 15:23 ` Derrick Stolee
2021-04-01 15:40 ` [PATCH 08/23] fsmonitor-fs-listen-macos: stub in backend for MacOS Jeff Hostetler via GitGitGadget
2021-04-01 15:40 ` [PATCH 09/23] fsmonitor--daemon: implement daemon command options Jeff Hostetler via GitGitGadget
2021-04-26 15:47 ` Derrick Stolee
2021-04-26 16:12 ` Derrick Stolee
2021-04-30 15:18 ` Jeff Hostetler
2021-04-30 15:59 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 10/23] fsmonitor--daemon: add pathname classification Jeff Hostetler via GitGitGadget
2021-04-26 19:17 ` Derrick Stolee
2021-04-26 20:11 ` Eric Sunshine
2021-04-26 20:24 ` Derrick Stolee
2021-04-01 15:40 ` [PATCH 11/23] fsmonitor--daemon: define token-ids Jeff Hostetler via GitGitGadget
2021-04-26 19:49 ` Derrick Stolee
2021-04-26 20:01 ` Eric Sunshine
2021-04-26 20:03 ` Derrick Stolee
2021-04-30 16:17 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 12/23] fsmonitor--daemon: create token-based changed path cache Jeff Hostetler via GitGitGadget
2021-04-26 20:22 ` Derrick Stolee
2021-04-30 17:36 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 13/23] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows Jeff Hostetler via GitGitGadget
2021-04-27 17:22 ` Derrick Stolee
2021-04-27 17:41 ` Eric Sunshine
2021-04-30 19:32 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 14/23] fsmonitor-fs-listen-macos: add macos header files for FSEvent Jeff Hostetler via GitGitGadget
2021-04-27 18:13 ` Derrick Stolee
2021-04-01 15:40 ` [PATCH 15/23] fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS Jeff Hostetler via GitGitGadget
2021-04-27 18:35 ` Derrick Stolee
2021-04-30 20:05 ` Jeff Hostetler
2021-04-01 15:40 ` [PATCH 16/23] fsmonitor--daemon: implement handle_client callback Jeff Hostetler via GitGitGadget
2021-04-26 21:01 ` Derrick Stolee
2021-05-03 15:04 ` Jeff Hostetler
2021-05-13 18:52 ` Derrick Stolee
2021-04-01 15:40 ` [PATCH 17/23] fsmonitor--daemon: periodically truncate list of modified files Jeff Hostetler via GitGitGadget
2021-04-27 13:24 ` Derrick Stolee
2021-04-01 15:41 ` [PATCH 18/23] fsmonitor--daemon:: introduce client delay for testing Jeff Hostetler via GitGitGadget
2021-04-27 13:36 ` Derrick Stolee
2021-04-01 15:41 ` [PATCH 19/23] fsmonitor--daemon: use a cookie file to sync with file system Jeff Hostetler via GitGitGadget
2021-04-27 14:23 ` Derrick Stolee
2021-05-03 21:59 ` Jeff Hostetler
2021-04-01 15:41 ` [PATCH 20/23] fsmonitor: force update index when fsmonitor token advances Jeff Hostetler via GitGitGadget
2021-04-27 14:52 ` Derrick Stolee
2021-04-01 15:41 ` [PATCH 21/23] t7527: create test for fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-04-27 15:41 ` Derrick Stolee
2021-04-01 15:41 ` [PATCH 22/23] p7519: add fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-04-27 15:45 ` Derrick Stolee
2021-04-01 15:41 ` [PATCH 23/23] t7527: test status with untracked-cache and fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-04-27 15:51 ` Derrick Stolee
2021-04-16 22:44 ` [PATCH 00/23] [RFC] Builtin FSMonitor Feature Junio C Hamano
2021-04-20 15:27 ` Johannes Schindelin
2021-04-20 19:13 ` Jeff Hostetler
2021-04-21 13:17 ` Derrick Stolee
2021-04-27 18:49 ` FS Monitor Windows Performance (was [PATCH 00/23] [RFC] Builtin FSMonitor Feature) Derrick Stolee
2021-04-27 19:31 ` FS Monitor macOS " Derrick Stolee
2021-05-22 13:56 ` [PATCH v2 00/28] Builtin FSMonitor Feature Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 01/28] simple-ipc: preparations for supporting binary messages Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 02/28] fsmonitor--daemon: man page Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 03/28] fsmonitor--daemon: update fsmonitor documentation Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 04/28] fsmonitor-ipc: create client routines for git-fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-06-02 11:24 ` Johannes Schindelin
2021-06-14 21:23 ` Johannes Schindelin
2021-05-22 13:56 ` [PATCH v2 05/28] help: include fsmonitor--daemon feature flag in version info Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 06/28] config: FSMonitor is repository-specific Johannes Schindelin via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 07/28] fsmonitor: introduce `core.useBuiltinFSMonitor` to call the daemon via IPC Johannes Schindelin via GitGitGadget
2021-06-14 21:28 ` Johannes Schindelin
2021-05-22 13:56 ` [PATCH v2 08/28] fsmonitor--daemon: add a built-in fsmonitor daemon Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 09/28] fsmonitor--daemon: implement client command options Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 10/28] t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon Jeff Hostetler via GitGitGadget
2021-06-11 6:32 ` Junio C Hamano
2021-05-22 13:56 ` [PATCH v2 11/28] fsmonitor-fs-listen-win32: stub in backend for Windows Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 12/28] fsmonitor-fs-listen-macos: stub in backend for MacOS Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 13/28] fsmonitor--daemon: implement daemon command options Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 14/28] fsmonitor--daemon: add pathname classification Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 15/28] fsmonitor--daemon: define token-ids Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 16/28] fsmonitor--daemon: create token-based changed path cache Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 17/28] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 18/28] fsmonitor-fs-listen-macos: add macos header files for FSEvent Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 19/28] fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS Jeff Hostetler via GitGitGadget
2021-05-22 13:56 ` [PATCH v2 20/28] fsmonitor--daemon: implement handle_client callback Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 21/28] fsmonitor--daemon: periodically truncate list of modified files Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 22/28] fsmonitor--daemon: use a cookie file to sync with file system Jeff Hostetler via GitGitGadget
2021-06-14 21:42 ` Johannes Schindelin
2021-05-22 13:57 ` [PATCH v2 23/28] fsmonitor: enhance existing comments Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 24/28] fsmonitor: force update index after large responses Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 25/28] t7527: create test for fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 26/28] p7519: add fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 27/28] t7527: test status with untracked-cache and fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-05-22 13:57 ` [PATCH v2 28/28] t/perf: avoid copying builtin fsmonitor files into test repo Jeff Hostetler via GitGitGadget
2021-05-27 2:06 ` [PATCH v2 00/28] Builtin FSMonitor Feature Junio C Hamano
2021-06-02 11:28 ` Johannes Schindelin
2021-06-22 15:45 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 00/34] " Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 01/34] simple-ipc: preparations for supporting binary messages Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 02/34] fsmonitor--daemon: man page Jeff Hostetler via GitGitGadget
2021-07-01 22:29 ` Ævar Arnfjörð Bjarmason
2021-07-05 22:00 ` Johannes Schindelin
2021-07-12 19:23 ` Jeff Hostetler
2021-07-13 17:46 ` Ævar Arnfjörð Bjarmason
2021-07-16 15:45 ` Johannes Schindelin
2021-07-16 17:04 ` Felipe Contreras
2021-07-01 14:47 ` [PATCH v3 03/34] fsmonitor--daemon: update fsmonitor documentation Jeff Hostetler via GitGitGadget
2021-07-01 22:31 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 04/34] fsmonitor-ipc: create client routines for git-fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 05/34] help: include fsmonitor--daemon feature flag in version info Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 06/34] fsmonitor: config settings are repository-specific Jeff Hostetler via GitGitGadget
2021-07-01 16:46 ` Ævar Arnfjörð Bjarmason
2021-07-19 20:36 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 07/34] fsmonitor: use IPC to query the builtin FSMonitor daemon Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 08/34] fsmonitor--daemon: add a built-in fsmonitor daemon Jeff Hostetler via GitGitGadget
2021-07-01 22:36 ` Ævar Arnfjörð Bjarmason
2021-07-19 20:56 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 09/34] fsmonitor--daemon: implement 'stop' and 'status' commands Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 10/34] t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon Jeff Hostetler via GitGitGadget
2021-07-01 22:41 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 11/34] fsmonitor-fs-listen-win32: stub in backend for Windows Jeff Hostetler via GitGitGadget
2021-07-01 22:45 ` Ævar Arnfjörð Bjarmason
2021-07-16 15:47 ` Johannes Schindelin
2021-07-16 16:55 ` Ævar Arnfjörð Bjarmason
2021-07-17 5:13 ` Junio C Hamano
2021-07-17 5:21 ` Junio C Hamano
2021-07-17 21:43 ` Ævar Arnfjörð Bjarmason
2021-07-19 19:58 ` Junio C Hamano
2021-07-16 16:59 ` Felipe Contreras
2021-07-19 16:54 ` Jeff Hostetler
2021-07-20 20:32 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 12/34] fsmonitor-fs-listen-macos: stub in backend for MacOS Jeff Hostetler via GitGitGadget
2021-07-01 22:49 ` Ævar Arnfjörð Bjarmason
2021-07-16 15:51 ` Johannes Schindelin
2021-07-16 16:52 ` Ævar Arnfjörð Bjarmason
2021-07-26 21:40 ` Johannes Schindelin
2021-07-26 23:26 ` Junio C Hamano
2021-07-27 12:46 ` Jeff Hostetler
2021-07-27 15:56 ` Ævar Arnfjörð Bjarmason
2021-07-27 17:25 ` Junio C Hamano
2021-07-27 17:45 ` Felipe Contreras
2021-07-01 14:47 ` [PATCH v3 13/34] fsmonitor--daemon: implement 'run' command Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 14/34] fsmonitor--daemon: implement 'start' command Jeff Hostetler via GitGitGadget
2021-07-01 22:18 ` Ævar Arnfjörð Bjarmason
2021-07-05 21:52 ` Johannes Schindelin
2021-07-13 14:39 ` Jeff Hostetler
2021-07-13 17:54 ` Ævar Arnfjörð Bjarmason
2021-07-13 18:44 ` Jeff Hostetler
2021-07-20 19:38 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 15/34] fsmonitor: do not try to operate on bare repos Jeff Hostetler via GitGitGadget
2021-07-01 22:53 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 16/34] fsmonitor--daemon: add pathname classification Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 17/34] fsmonitor--daemon: define token-ids Jeff Hostetler via GitGitGadget
2021-07-01 22:58 ` Ævar Arnfjörð Bjarmason
2021-07-13 15:15 ` Jeff Hostetler
2021-07-13 18:11 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 18/34] fsmonitor--daemon: create token-based changed path cache Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 19/34] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows Jeff Hostetler via GitGitGadget
2021-07-01 23:02 ` Ævar Arnfjörð Bjarmason
2021-07-13 15:46 ` Jeff Hostetler
2021-07-13 18:15 ` Ævar Arnfjörð Bjarmason
2021-07-16 15:55 ` Johannes Schindelin
2021-07-16 16:27 ` Ævar Arnfjörð Bjarmason
2021-07-17 12:45 ` Eric Wong
2021-07-19 22:35 ` Jeff Hostetler
2021-07-16 16:55 ` Felipe Contreras
2021-07-06 19:09 ` Johannes Schindelin
2021-07-13 15:18 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 20/34] fsmonitor-fs-listen-macos: add macos header files for FSEvent Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 21/34] fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 22/34] fsmonitor--daemon: implement handle_client callback Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 23/34] t/helper/test-touch: add helper to touch a series of files Jeff Hostetler via GitGitGadget
2021-07-01 20:00 ` Junio C Hamano
2021-07-13 16:45 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 24/34] t/perf/p7519: speed up test using "test-tool touch" Jeff Hostetler via GitGitGadget
2021-07-01 23:09 ` Ævar Arnfjörð Bjarmason
2021-07-13 17:06 ` Jeff Hostetler
2021-07-13 17:36 ` Elijah Newren
2021-07-13 17:47 ` Junio C Hamano
2021-07-13 17:50 ` Elijah Newren
2021-07-13 17:58 ` Jeff Hostetler
2021-07-13 18:07 ` Junio C Hamano
2021-07-13 18:19 ` Jeff Hostetler
2021-07-13 18:18 ` Ævar Arnfjörð Bjarmason
2021-07-13 19:05 ` Jeff Hostetler
2021-07-20 19:18 ` Ævar Arnfjörð Bjarmason
2021-07-13 18:04 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 25/34] t/perf: avoid copying builtin fsmonitor files into test repo Jeff Hostetler via GitGitGadget
2021-07-01 23:11 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 26/34] t/perf/p7519: add fsmonitor--daemon test cases Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 27/34] t7527: create test for fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-07-01 23:15 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:47 ` [PATCH v3 28/34] fsmonitor--daemon: periodically truncate list of modified files Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 29/34] fsmonitor--daemon: use a cookie file to sync with file system Jeff Hostetler via GitGitGadget
2021-07-01 23:17 ` Ævar Arnfjörð Bjarmason
2021-07-21 14:40 ` Jeff Hostetler
2021-07-01 14:47 ` [PATCH v3 30/34] fsmonitor: enhance existing comments Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 31/34] fsmonitor: force update index after large responses Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 32/34] t7527: test status with untracked-cache and fsmonitor--daemon Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 33/34] fsmonitor: handle shortname for .git Jeff Hostetler via GitGitGadget
2021-07-01 14:47 ` [PATCH v3 34/34] t7527: test FS event reporing on MacOS WRT case and Unicode Jeff Hostetler via GitGitGadget
2021-07-01 23:39 ` Ævar Arnfjörð Bjarmason
2021-07-01 17:40 ` [PATCH v3 00/34] Builtin FSMonitor Feature Ævar Arnfjörð Bjarmason
2021-07-01 18:29 ` Jeff Hostetler
2021-07-01 21:26 ` Ævar Arnfjörð Bjarmason
2021-07-02 19:06 ` Jeff Hostetler
2021-07-05 22:52 ` Ævar Arnfjörð Bjarmason
2021-07-05 21:35 ` Johannes Schindelin
2021-07-05 22:02 ` Ævar Arnfjörð Bjarmason
2021-07-06 13:12 ` Johannes Schindelin
2021-07-07 2:14 ` Felipe Contreras
2021-07-07 1:53 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mttkyrqq.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=johannes.schindelin@gmx.de \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).