git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: ab/parse-options-cleanup
Date: Fri, 01 Oct 2021 16:32:26 +0200	[thread overview]
Message-ID: <87mtnsrf06.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqh7e18soj.fsf@gitster.g>


On Thu, Sep 30 2021, Junio C Hamano wrote:

> * ab/parse-options-cleanup (2021-09-28) 10 commits
>  - parse-options: change OPT_{SHORT,UNSET} to an enum
>  - parse-options tests: test optname() output
>  - parse-options.[ch]: make opt{bug,name}() "static"
>  - commit-graph: stop using optname()
>  - parse-options.c: move optname() earlier in the file
>  - parse-options.h: make the "flags" in "struct option" an enum
>  - parse-options.c: use exhaustive "case" arms for "enum parse_opt_type"
>  - parse-options.[ch]: consistently use "enum parse_opt_result"
>  - parse-options.[ch]: consistently use "enum parse_opt_flags"
>  - parse-options.h: move PARSE_OPT_SHELL_EVAL between enums
>
>  Random changes to parse-options implementation.
>
>  What's the status of this one?  Meh?

Re-rolled just now at
https://lore.kernel.org/git/cover-v2-00.11-00000000000-20211001T142631Z-avarab@gmail.com/

I could rebase on it being ejected, but I've got some niceties in
parse_options() currently depending on it, and as notedi in the updated
02/11 I think that "enum bitfield" pattern is worth it under
debuggers. So it would be great if it could advance. Thanks!

  parent reply	other threads:[~2021-10-01 14:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  1:01 What's cooking in git.git (Sep 2021, #09; Thu, 30) Junio C Hamano
2021-10-01  6:20 ` en/removing-untracked-fixes [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)] Elijah Newren
2021-10-01  8:51   ` Ævar Arnfjörð Bjarmason
2021-10-01 17:05   ` en/removing-untracked-fixes [ Junio C Hamano
2021-10-01  6:31 ` en/remerge-diff [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)] Elijah Newren
2021-10-01  7:01   ` Jeff King
2021-10-01 12:05 ` What's cooking in git.git (Sep 2021, #09; Thu, 30) Ævar Arnfjörð Bjarmason
2021-10-01 12:08 ` ab/fsck-unexpected-type Ævar Arnfjörð Bjarmason
2021-10-01 14:32 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-01 14:35 ` ab/sanitize-leak-ci & more leak fixes soon-or-not Ævar Arnfjörð Bjarmason
2021-10-01 14:48 ` ab/refs-errno-cleanup Ævar Arnfjörð Bjarmason
2021-10-01 14:56 ` What's cooking in git.git (Sep 2021, #09; Thu, 30) Jeff Hostetler
2021-10-01 15:01 ` ab/align-parse-options-help & ab/help-config-vars Ævar Arnfjörð Bjarmason
2021-10-01 15:05 ` ab/lib-subtest Ævar Arnfjörð Bjarmason
2021-10-01 15:07 ` ab/config-based-hooks-1 Ævar Arnfjörð Bjarmason
  -- strict thread matches above, loose matches on Subject: below --
2021-10-12  0:14 What's cooking in git.git (Oct 2021, #03; Mon, 11) Junio C Hamano
2021-10-13 13:47 ` ab/parse-options-cleanup Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtnsrf06.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).