From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> To: Han-Wen Nienhuys <hanwen@google.com> Cc: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>, git <git@vger.kernel.org>, Jeff King <peff@peff.net>, Ramsay Jones <ramsay@ramsayjones.plus.com>, Jonathan Nieder <jrnieder@gmail.com>, Johannes Schindelin <Johannes.Schindelin@gmx.de>, Jonathan Tan <jonathantanmy@google.com>, Josh Steadmon <steadmon@google.com>, Emily Shaffer <emilyshaffer@google.com>, Patrick Steinhardt <ps@pks.im>, Felipe Contreras <felipe.contreras@gmail.com>, Derrick Stolee <stolee@gmail.com>, Han-Wen Nienhuys <hanwenn@gmail.com> Subject: Re: [PATCH v7 00/28] reftable library Date: Wed, 21 Apr 2021 13:21:30 +0200 [thread overview] Message-ID: <87lf9b3mth.fsf@evledraar.gmail.com> (raw) In-Reply-To: <CAFQ2z_MF3SbKf8yXBvkOcLGg03dVxJW3F=c6ZDUtstEbZUUMCQ@mail.gmail.com> On Wed, Apr 21 2021, Han-Wen Nienhuys wrote: > On Wed, Apr 21, 2021 at 9:45 AM Ævar Arnfjörð Bjarmason > <avarab@gmail.com> wrote: >> > The commits up to "hash.h: provide constants for the hash IDs" should be >> > good to merge to 'next'. >> >> With how Junio queues things up perhaps submitting this as another >> "prep" series would be good, to reduce future reviewer fatigue, >> i.e. anything we can make land on master makes re-rolls that much >> smaller. > > will do. > >> > There are several test fixups, but I've put them in another series because >> > GGG enforces max 30 commits. >> >> I left a bunch of comments on the test prep series now. Probably good to >> have it split up regardless of GGG limits. >> >> Re the comments I left on the test series. I'm very happy to see the >> start of addressing the "it must be tested" concerns I had in >> https://lore.kernel.org/git/87wnt2th1v.fsf@evledraar.gmail.com/ > > It may look like the start, but I've been improving the number of > tests that pass continuously since I posted the first version of this > code over a year ago. FWIW I meant or meant to say something closer to "a start at the numerous failures I noted in the v6 discussion", not "no work has been done at all on this front". Sorry. >> I don't see the point of having re-rolls of this topic while the test >> changes topic it's based on hasn't finished >> marking/splitting/refactoring the various tests that do and don't depend >> on the file backend. >> >> At least when I review it I'm just left with going in circles digging >> into one of those failing test, figuring out if it's really >> refs/files-backend.c specific or not etc., and as long as we can't turn >> on GIT_TEST_REFTABLE=true in CI as part of this series I don't see a >> path to making it advance to next->master. > > The point of posting updates is to garner feedback, especially from > people familiar with the Git code itself. So you agree that we should make the tests pass first, then shouldn't these me marked as RFC/PATCH? I for one would find that a lot less confusing, "PATCH" means "the author considers this ready to land on master sans undiscovered bugs etc. > If you would like this effort to move forward faster, Yes, I'm keen to help move it forward. I am saying that I think for me or anyone else to do that in any sensible way the path forward is to make the tests pass with GIT_TEST_REFTABLE=true. IOW a large part of the feedback you're looking for is already part of the codebase. Nobody can keep all of it in their head, but we've encoded all the tricky edge cases we could think of in the tests. So in particular per my feedback on the test series: It's only when we start digging into those tests that we discover the interesting bits, i.e. how things like .git/SOME_FILE behaves per[1], and my comments about reflog behavior in [2]. Anyway, I think I'm just repeating myself at this point, but part of the reason is that I don't think I've gotten a straight answer about the point-by-point questions I had in [3]. I.e. reaching some consensus on things like whether GIT_TEST_REFTABLE=true passing under CI being a hard-prereq for this series or not is surely one of the first things to sketch out before figuring out how to move this forward. Also, with how unhappy Junio is with my patch-dumping I'm probably the last person to give advice about managing mailing list attention, but still: here's an attempt: In v6 I noted that t5510-fetch.sh had a segfault[4], you said you'd check it out, and reading your cover letter nothing stood out about that, so I assumed it was sorted out somehow. But running it now yields a BUG() instead: BUG: refs.c:1038: free called on a prepared reference transaction Aborted [...] not ok 18 - fetch --atomic aborts all reference updates if hook aborts And trying the whole test suite with --verbose-log yields: $ grep -e 'Segmentation fault' -e BUG: test-results/* test-results/t0210-trace2-normal.out:BUG: t/helper/test-trace2.c:206: the bug message test-results/t1400-update-ref.out:BUG: refs.c:1038: free called on a prepared reference transaction test-results/t1400-update-ref.out:BUG: refs.c:1038: free called on a prepared reference transaction test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t5510-fetch.out:BUG: refs.c:1038: free called on a prepared reference transaction test-results/t5510-fetch.out:BUG: refs.c:1038: free called on a prepared reference transaction test-results/t5600-clone-fail-cleanup.out:Segmentation fault test-results/t5600-clone-fail-cleanup.out:Segmentation fault test-results/t5600-clone-fail-cleanup.out:Segmentation fault test-results/t5601-clone.out:Segmentation fault test-results/t6423-merge-rename-directories.out: test_i18ngrep ! BUG: err && Not all of that is yours, FWIW "seen" is currently doing, and the "diff" failures are ac14de13b2 (t4058: explore duplicate tree entry handling in a bit more detail, 2020-12-11). $ grep -e 'Segmentation fault' -e BUG: test-results/* test-results/t0210-trace2-normal.out:BUG: t/helper/test-trace2.c:206: the bug message test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation pack_refs requires abilities 0x6, but only have 0x5 test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation create_symref requires abilities 0x2, but only have 0x5 test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation delete_refs requires abilities 0x2, but only have 0x5 test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation rename_ref requires abilities 0x2, but only have 0x5 test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation delete_reflog requires abilities 0x2, but only have 0x5 test-results/t1406-submodule-ref-store.out:BUG: refs/files-backend.c:139: operation create_reflog requires abilities 0x2, but only have 0x5 test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t4058-diff-duplicates.out:Segmentation fault test-results/t6423-merge-rename-directories.out: test_i18ngrep ! BUG: err && Anyway, the "clone"/"fetch"/"update-ref" failures look new with GIT_TEST_REFTABLE=true. So to close up the attempt at getting feedback: I think we'd probably be better off still discussing "I tried this to fix the segfault, but now I get this BUG" rather than a 30 patch re-roll. > I am most in need of review for the part that glues the library > together with the git code itself (ie. the commit introducing > refs/reftable-backend.c). In other and briefer words I don't think this series is in need of review at this point, it's in need of *addressing* review, where review is both the ghosts from the past of failing tests, and outstanding segfaults/BUG()s being hit. 1. https://lore.kernel.org/git/87k0ow2n29.fsf@evledraar.gmail.com/ 2. https://lore.kernel.org/git/87pmyo3zvw.fsf@evledraar.gmail.com/ 3. https://lore.kernel.org/git/87wnt2th1v.fsf@evledraar.gmail.com/ 4. https://lore.kernel.org/git/87im4qejpk.fsf@evledraar.gmail.com/
next prev parent reply other threads:[~2021-04-21 11:21 UTC|newest] Thread overview: 251+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-16 19:10 [PATCH 00/13] " Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 01/13] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 02/13] reftable: define the public API Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 03/13] vcxproj: adjust for the reftable changes Johannes Schindelin via GitGitGadget 2020-09-16 19:10 ` [PATCH 04/13] reftable: add a barebones unittest framework Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 05/13] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 06/13] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-09-20 1:00 ` Junio C Hamano 2020-09-21 13:13 ` Han-Wen Nienhuys 2020-09-24 7:21 ` Jeff King 2020-09-24 7:31 ` Jeff King 2020-09-24 17:22 ` Junio C Hamano 2020-09-16 19:10 ` [PATCH 07/13] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 08/13] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 09/13] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 10/13] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 11/13] reftable: file level tests Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 12/13] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 13/13] reftable: "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 00/13] reftable library Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 01/13] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-10-02 3:18 ` Jonathan Nieder 2020-10-01 16:10 ` [PATCH v2 02/13] reftable: define the public API Han-Wen Nienhuys via GitGitGadget 2020-10-02 3:58 ` Jonathan Nieder 2020-10-09 21:13 ` Emily Shaffer 2020-10-10 17:03 ` Han-Wen Nienhuys 2020-11-30 14:44 ` Han-Wen Nienhuys 2020-10-10 13:43 ` Han-Wen Nienhuys 2020-10-12 16:57 ` Jonathan Nieder 2020-11-30 14:55 ` Han-Wen Nienhuys 2020-10-08 1:41 ` Jonathan Tan 2020-10-10 16:57 ` Han-Wen Nienhuys 2020-10-01 16:10 ` [PATCH v2 03/13] vcxproj: adjust for the reftable changes Johannes Schindelin via GitGitGadget 2020-10-02 4:02 ` Jonathan Nieder 2020-10-02 11:43 ` Johannes Schindelin 2020-10-01 16:10 ` [PATCH v2 04/13] reftable: add a barebones unittest framework Han-Wen Nienhuys via GitGitGadget 2020-10-02 4:05 ` Jonathan Nieder 2020-10-08 1:45 ` Jonathan Tan 2020-10-08 22:31 ` Josh Steadmon 2020-10-01 16:10 ` [PATCH v2 05/13] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-10-02 4:12 ` Jonathan Nieder 2020-10-10 17:32 ` Han-Wen Nienhuys 2020-10-12 15:25 ` Jonathan Nieder 2020-10-12 17:05 ` Patrick Steinhardt 2020-10-12 17:45 ` Jonathan Nieder 2020-10-13 12:12 ` Johannes Schindelin 2020-10-13 15:47 ` Junio C Hamano 2020-10-15 11:46 ` Johannes Schindelin 2020-10-15 16:23 ` Junio C Hamano 2020-10-15 19:39 ` Johannes Schindelin 2020-10-16 9:15 ` Patrick Steinhardt 2020-10-02 14:01 ` Johannes Schindelin 2020-10-02 20:47 ` Junio C Hamano 2020-10-03 8:07 ` Johannes Schindelin 2020-10-08 1:48 ` Jonathan Tan 2020-10-10 17:28 ` Han-Wen Nienhuys 2020-10-11 10:52 ` Johannes Schindelin 2020-10-12 15:19 ` Jonathan Nieder 2020-10-12 18:44 ` Johannes Schindelin 2020-10-12 19:41 ` Jonathan Nieder 2020-10-12 20:27 ` Johannes Schindelin 2020-10-12 16:42 ` Junio C Hamano 2020-10-12 19:01 ` Johannes Schindelin 2020-10-23 9:13 ` Ævar Arnfjörð Bjarmason 2020-10-23 17:36 ` Junio C Hamano 2020-10-01 16:10 ` [PATCH v2 06/13] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-10-01 19:23 ` Junio C Hamano 2020-10-01 19:59 ` Ramsay Jones 2020-10-01 16:10 ` [PATCH v2 07/13] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 08/13] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 09/13] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 10/13] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 11/13] reftable: file level tests Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 12/13] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-10-02 13:57 ` Johannes Schindelin 2020-10-02 17:08 ` Junio C Hamano 2020-10-04 18:39 ` Johannes Schindelin 2020-10-01 16:11 ` [PATCH v2 13/13] reftable: "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 00/16] reftable library Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 01/16] move sleep_millisec to git-compat-util.h Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 02/16] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:22 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 03/16] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:23 ` Ævar Arnfjörð Bjarmason 2020-11-30 11:26 ` Han-Wen Nienhuys 2020-11-30 20:25 ` Han-Wen Nienhuys 2020-11-30 21:21 ` Felipe Contreras 2020-12-01 9:51 ` Han-Wen Nienhuys 2020-12-01 10:38 ` Felipe Contreras 2020-12-01 11:45 ` Ævar Arnfjörð Bjarmason 2020-12-01 13:34 ` Han-Wen Nienhuys 2020-12-01 23:13 ` Felipe Contreras 2020-12-01 23:03 ` Felipe Contreras 2020-11-26 19:42 ` [PATCH v3 04/16] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2020-11-27 9:13 ` Felipe Contreras 2020-11-27 10:25 ` Ævar Arnfjörð Bjarmason 2020-11-30 11:27 ` Han-Wen Nienhuys 2020-11-26 19:42 ` [PATCH v3 05/16] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:18 ` Felipe Contreras 2020-11-27 10:33 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 06/16] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 07/16] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 08/16] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 09/16] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 10/16] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 11/16] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 12/16] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 13/16] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 14/16] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:59 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 15/16] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 16/16] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 00/15] reftable library Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 01/15] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 02/15] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 03/15] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 04/15] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 05/15] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 06/15] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 07/15] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 08/15] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 09/15] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 10/15] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 11/15] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 12/15] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 13/15] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-01-21 15:55 ` Ævar Arnfjörð Bjarmason 2021-01-21 16:14 ` Han-Wen Nienhuys 2021-01-21 16:21 ` Han-Wen Nienhuys 2021-01-26 13:44 ` Ævar Arnfjörð Bjarmason 2021-04-23 10:22 ` Han-Wen Nienhuys 2021-04-26 13:23 ` Ævar Arnfjörð Bjarmason 2021-04-26 16:17 ` Han-Wen Nienhuys 2021-04-28 16:32 ` Ævar Arnfjörð Bjarmason 2021-04-28 17:40 ` Han-Wen Nienhuys 2021-02-22 0:41 ` [PATCH] refs: introduce API function to write invalid null ref Stefan Beller 2021-02-22 1:20 ` Eric Sunshine 2021-02-22 3:09 ` Eric Sunshine 2021-02-22 18:38 ` Han-Wen Nienhuys 2020-12-09 14:00 ` [PATCH v4 14/15] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 15/15] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 00/15] reftable library Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 01/15] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 02/15] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 03/15] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 04/15] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 05/15] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 06/15] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 07/15] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 08/15] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 09/15] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 10/15] reftable: read " Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 11/15] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 12/15] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 13/15] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-03-23 11:40 ` Derrick Stolee 2021-03-23 12:20 ` Ævar Arnfjörð Bjarmason 2021-03-23 20:14 ` Junio C Hamano 2021-03-23 20:12 ` Junio C Hamano 2021-03-12 20:19 ` [PATCH v5 14/15] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 15/15] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 00/20] reftable library Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 01/20] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 02/20] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-04-13 7:28 ` Ævar Arnfjörð Bjarmason 2021-04-13 10:50 ` Han-Wen Nienhuys 2021-04-13 13:41 ` Ævar Arnfjörð Bjarmason 2021-04-12 19:25 ` [PATCH v6 03/20] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 04/20] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-04-13 8:02 ` Ævar Arnfjörð Bjarmason 2021-04-13 10:58 ` Han-Wen Nienhuys 2021-04-13 12:56 ` Ævar Arnfjörð Bjarmason 2021-04-13 13:14 ` Ævar Arnfjörð Bjarmason 2021-04-15 15:00 ` Han-Wen Nienhuys 2021-04-12 19:25 ` [PATCH v6 05/20] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 06/20] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 07/20] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-04-12 21:40 ` Junio C Hamano 2021-04-13 8:19 ` Ævar Arnfjörð Bjarmason 2021-04-15 8:57 ` Han-Wen Nienhuys 2021-04-12 19:25 ` [PATCH v6 08/20] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 09/20] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 10/20] reftable: generic interface to tables Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 11/20] reftable: read reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 12/20] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 13/20] reftable: add a heap-based priority queue for reftable records Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 14/20] reftable: add merged table view Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 15/20] reftable: implement refname validation Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 16/20] reftable: implement stack, a mutable database of reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 17/20] reftable: add dump utility Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 18/20] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-04-13 7:18 ` Ævar Arnfjörð Bjarmason 2021-04-14 16:44 ` Han-Wen Nienhuys 2021-04-16 14:55 ` Ævar Arnfjörð Bjarmason 2021-04-16 18:47 ` Junio C Hamano 2021-04-12 19:25 ` [PATCH v6 19/20] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 20/20] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 00/28] reftable library Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 01/28] refs: ref_iterator_peel returns boolean, rather than peel_status Han-Wen Nienhuys via GitGitGadget 2021-04-20 18:47 ` Junio C Hamano 2021-04-21 10:15 ` Han-Wen Nienhuys 2021-04-21 23:28 ` Junio C Hamano 2021-04-19 11:37 ` [PATCH v7 02/28] refs: document reflog_expire_fn's flag argument Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:34 ` Junio C Hamano 2021-04-27 15:21 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 03/28] refs/debug: trace into reflog expiry too Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:41 ` Junio C Hamano 2021-04-22 17:27 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 04/28] hash.h: provide constants for the hash IDs Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:49 ` Junio C Hamano 2021-04-21 1:04 ` brian m. carlson 2021-04-21 9:43 ` Han-Wen Nienhuys 2021-07-22 8:31 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 05/28] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 06/28] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-04-21 7:48 ` Ævar Arnfjörð Bjarmason 2021-04-21 9:15 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 07/28] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 08/28] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 09/28] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 10/28] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-05-04 17:23 ` Andrzej Hunt 2021-05-18 13:12 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 11/28] Provide zlib's uncompress2 from compat/zlib-compat.c Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 12/28] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 13/28] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 14/28] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 15/28] reftable: generic interface to tables Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 16/28] reftable: read reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 17/28] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 18/28] reftable: add a heap-based priority queue for reftable records Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 19/28] reftable: add merged table view Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 20/28] reftable: implement refname validation Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 21/28] reftable: implement stack, a mutable database of reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 22/28] reftable: add dump utility Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 23/28] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-04-20 22:44 ` Junio C Hamano 2021-04-21 10:19 ` Han-Wen Nienhuys 2021-04-21 23:22 ` Junio C Hamano 2021-05-04 17:24 ` Andrzej Hunt 2021-05-18 13:18 ` Han-Wen Nienhuys 2021-05-18 13:30 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 24/28] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 25/28] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 26/28] t1301: document what needs to be done for REFTABLE Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 27/28] t1401,t2011: parameterize HEAD.lock " Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 28/28] t1404: annotate test cases with REFFILES Han-Wen Nienhuys via GitGitGadget 2021-04-21 7:45 ` [PATCH v7 00/28] reftable library Ævar Arnfjörð Bjarmason 2021-04-21 9:52 ` Han-Wen Nienhuys 2021-04-21 11:21 ` Ævar Arnfjörð Bjarmason [this message] 2021-04-26 17:59 ` Han-Wen Nienhuys
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lf9b3mth.fsf@evledraar.gmail.com \ --to=avarab@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=emilyshaffer@google.com \ --cc=felipe.contreras@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=hanwen@google.com \ --cc=hanwenn@gmail.com \ --cc=jonathantanmy@google.com \ --cc=jrnieder@gmail.com \ --cc=peff@peff.net \ --cc=ps@pks.im \ --cc=ramsay@ramsayjones.plus.com \ --cc=steadmon@google.com \ --cc=stolee@gmail.com \ --subject='Re: [PATCH v7 00/28] reftable library' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).