From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: Elijah Newren <newren@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)
Date: Tue, 06 Jul 2021 21:29:38 +0200 [thread overview]
Message-ID: <87k0m35jfi.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <d04c71fe-acfb-abe0-b00f-cfa01651dd57@gmail.com>
On Tue, Jul 06 2021, Phillip Wood wrote:
> On 03/07/2021 06:04, Elijah Newren wrote:
>> On Wed, Jun 30, 2021 at 3:58 PM Junio C Hamano <gitster@pobox.com> wrote:
>>> * pw/diff-color-moved-fix (2021-06-15) 10 commits
>>> - diff --color-moved: intern strings
>>> - diff --color-moved-ws=allow-indentation-change: improve hash lookups
>>> - diff --color-moved: stop clearing potential moved blocks
>>> - diff --color-moved: shrink potential moved blocks as we go
>>> - diff --color-moved: unify moved block growth functions
>>> - diff --color-moved: call comparison function directly
>>> - diff --color-moved-ws=allow-indentation-change: simplify and optimize
>>> - diff: simplify allow-indentation-change delta calculation
>>> - diff --color-moved: avoid false short line matches and bad zebra coloring
>>> - diff --color-moved=zebra: fix alternate coloring
>>>
>>> Long-overdue correctness and performance update to "diff
>>> --color-moved" feature.
>>>
>>> Waiting for reviews.
>> I read through the first half the patches or so and didn't spot
>> anything wrong, though I'm very unfamiliar with this code area and
>> don't yet understand much of what's going on; it was more of a spot
>> check. I'll try to get back to it again, but my review probably won't
>> be that deep.
>
> Thanks for taking a look, do let me know if I can do anything to make
> reviewing this series easier
FWIW I put it on my own mental list of "waiting for re-roll" per [1].
(Not that you need to take my suggestion there, just that you seemed to
agree, so I thought I'd take a look when that happened in a v2).
1. https://lore.kernel.org/git/094f5e5f-d447-8867-a9a7-be5c8827bba6@gmail.com/
next prev parent reply other threads:[~2021-07-06 19:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 22:55 What's cooking in git.git (Jun 2021, #07; Wed, 30) Junio C Hamano
2021-07-01 0:02 ` Felipe Contreras
[not found] ` <CAFQ2z_PYJMzOBcN+KoQSfdD-eYtZVzrArL0Dh-YW-q3R8hgm2w@mail.gmail.com>
2021-07-01 7:19 ` Han-Wen Nienhuys
2021-07-01 13:06 ` Ævar Arnfjörð Bjarmason
2021-07-01 13:42 ` Ævar Arnfjörð Bjarmason
2021-07-01 14:20 ` Jeff Hostetler
2021-07-01 14:00 ` Ævar Arnfjörð Bjarmason
2021-07-01 15:21 ` Junio C Hamano
2021-07-02 12:18 ` Ævar Arnfjörð Bjarmason
2021-07-02 16:05 ` Junio C Hamano
2021-07-01 16:51 ` Jeff King
2021-07-01 16:20 ` Jeff King
2021-07-03 5:04 ` Elijah Newren
2021-07-05 8:03 ` Ævar Arnfjörð Bjarmason
2021-07-05 12:02 ` Jeff King
2021-07-06 13:46 ` Phillip Wood
2021-07-06 19:29 ` Ævar Arnfjörð Bjarmason [this message]
2021-07-06 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0m35jfi.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).