From: Sergey Organov <sorganov@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] stash: get rid of unused argument in stash_staged()
Date: Thu, 28 Oct 2021 11:29:34 +0300 [thread overview]
Message-ID: <87k0hx5z81.fsf_-_@osv.gnss.ru> (raw)
In-Reply-To: <xmqqfssmupvq.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 27 Oct 2021 14:19:53 -0700")
Unused 'ps' argument was a left-over from original copy-paste of
stash_patch(). Removed.
Signed-off-by: Sergey Organov <sorganov@gmail.com>
---
builtin/stash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/stash.c b/builtin/stash.c
index 8d6f0e582ce0..18c812bbe032 100644
--- a/builtin/stash.c
+++ b/builtin/stash.c
@@ -1132,8 +1132,8 @@ static int save_untracked_files(struct stash_info *info, struct strbuf *msg,
return ret;
}
-static int stash_staged(struct stash_info *info, const struct pathspec *ps,
- struct strbuf *out_patch, int quiet)
+static int stash_staged(struct stash_info *info, struct strbuf *out_patch,
+ int quiet)
{
int ret = 0;
struct child_process cp_diff_tree = CHILD_PROCESS_INIT;
@@ -1370,7 +1370,7 @@ static int do_create_stash(const struct pathspec *ps, struct strbuf *stash_msg_b
goto done;
}
} else if (only_staged) {
- ret = stash_staged(info, ps, patch, quiet);
+ ret = stash_staged(info, patch, quiet);
if (ret < 0) {
if (!quiet)
fprintf_ln(stderr, _("Cannot save the current "
--
2.25.1
next prev parent reply other threads:[~2021-10-28 8:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 22:12 [PATCH RFC] stash: implement '--staged' option for 'push' and 'save' Sergey Organov
2021-10-11 20:16 ` [PATCH RFC v1] " Sergey Organov
2021-10-11 21:21 ` Eric Sunshine
2021-10-11 21:55 ` Sergey Organov
2021-10-12 9:18 ` Ævar Arnfjörð Bjarmason
2021-10-12 11:20 ` Sergey Organov
2021-10-12 12:04 ` Junio C Hamano
2021-10-12 12:34 ` Junio C Hamano
2021-10-12 16:07 ` Sergey Organov
2021-10-12 17:28 ` Junio C Hamano
2021-10-12 18:25 ` Sergey Organov
2021-10-13 4:48 ` Junio C Hamano
2021-10-13 13:43 ` Sergey Organov
2021-10-15 15:04 ` [PATCH v2] " Sergey Organov
2021-10-15 17:58 ` Junio C Hamano
2021-10-15 19:05 ` Sergey Organov
2021-10-15 19:22 ` Junio C Hamano
2021-10-15 20:14 ` Sergey Organov
2021-10-15 20:21 ` Sergey Organov
2021-10-18 16:09 ` [PATCH v3] " Sergey Organov
2021-10-26 5:05 ` Jeff King
2021-10-27 15:11 ` Sergey Organov
2021-10-27 15:20 ` [PATCH v4] " Sergey Organov
2021-10-27 21:19 ` Junio C Hamano
2021-10-28 8:29 ` Sergey Organov [this message]
2021-10-28 21:17 ` [PATCH] stash: get rid of unused argument in stash_staged() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hx5z81.fsf_-_@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).