From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Loganaden Velvindron <logan@hackers.mu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow use of TLS 1.3
Date: Fri, 23 Mar 2018 19:37:08 +0100 [thread overview]
Message-ID: <87in9my6y3.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180323182506.GA15493@voidlinux>
On Fri, Mar 23 2018, Loganaden Velvindron wrote:
> Done during IETF 101 hackathon
Hi. Thanks. Let's add a meaningful commit message to this though,
something like:
Add a tlsv1.3 option to http.sslVersion in addition to the existing
tlsv1.[012] options. libcurl has supported this since 7.52.0.
> --- a/http.c
> +++ b/http.c
> @@ -61,6 +61,9 @@ static struct {
> { "tlsv1.0", CURL_SSLVERSION_TLSv1_0 },
> { "tlsv1.1", CURL_SSLVERSION_TLSv1_1 },
> { "tlsv1.2", CURL_SSLVERSION_TLSv1_2 },
> +#if LIBCURL_VERSION_NUM >= 0x075200
> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 }
> +#endif
I wonder if this wouldn't be better as:
+#ifdef CURL_SSLVERSION_TLSv1_3
+ { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 }
+#endif
We've been bitten before by doing version checks on libcurl code, only
to find that some distros are actively backporting features, so checking
the specific macros is usually better.
> #endif
> };
> #if LIBCURL_VERSION_NUM >= 0x070903
next prev parent reply other threads:[~2018-03-23 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 18:25 [PATCH] Allow use of TLS 1.3 Loganaden Velvindron
2018-03-23 18:37 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-23 18:39 ` Loganaden Velvindron
2018-03-23 23:37 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in9my6y3.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=logan@hackers.mu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).