From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: git@vger.kernel.org, "Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com> Subject: Re: [PATCH 1/2] gc docs: change --keep-base-pack to --keep-largest-pack Date: Mon, 23 Nov 2020 11:18:29 +0100 Message-ID: <87h7pgpea2.fsf@evledraar.gmail.com> (raw) In-Reply-To: <xmqqtutisdfk.fsf@gitster.c.googlers.com> On Sat, Nov 21 2020, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> The --keep-base-pack option never existed in git.git. It was the name >> for the --keep-largest-pack option in earlier revisions of that series >> before it landed as ae4e89e549 ("gc: add --keep-largest-pack option", >> 2018-04-15). > > Is it a sign that this hasn't been used by or useful to our users > that this documentation bug did not get noticed by anybody for the > past 30 months, I wonder. FWIW I used it in a major git deployment since before it landed on "master" as gc.bigPackThreshold, but not the CLI option. I think a lot of these CLI options for gc/repack are relatively unused compared to the config, but it's still arguably useful to have them for one-off testing (although you could also just use "git -c ..."). > "git gc -h" does report the option with correct name, which is the > beauty of automation ;-) > > Thanks, both. Will queue, together with [2/2] which also makes > sense.
next prev parent reply other threads:[~2020-11-23 10:22 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-06 21:49 gc docs: git gc --keep-base-pack ? Luc Van Oostenryck 2020-11-20 11:55 ` [PATCH 1/2] gc docs: change --keep-base-pack to --keep-largest-pack Ævar Arnfjörð Bjarmason 2020-11-21 19:43 ` Junio C Hamano 2020-11-23 10:18 ` Ævar Arnfjörð Bjarmason [this message] 2020-11-20 11:55 ` [PATCH 2/2] gc: rename keep_base_pack variable for --keep-largest-pack Ævar Arnfjörð Bjarmason
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h7pgpea2.fsf@evledraar.gmail.com \ --to=avarab@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=luc.vanoostenryck@gmail.com \ --cc=pclouds@gmail.com \ --subject='Re: [PATCH 1/2] gc docs: change --keep-base-pack to --keep-largest-pack' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git