From: Keshav Kini <keshav.kini@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Milton Soares Filho <milton.soares.filho@gmail.com>
Subject: Re: [PATCH] graph.c: visual difference on subsequent series
Date: Mon, 28 Oct 2013 11:59:47 -0500 [thread overview]
Message-ID: <87fvrljpq4.fsf@gmail.com> (raw)
In-Reply-To: <xmqqeh75h087.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 28 Oct 2013 08:41:12 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> [administrivia: please avoid culling addresses from To:/Cc: lines]
Yikes, sorry about that. I've been sending messages through Gmane
rather than via email, and I didn't realize the list didn't
automatically send messages to the appropriate people who are only
reading the list via actual email (as I am not such a person).
> Keshav Kini <keshav.kini@gmail.com> writes:
>> What about just putting an extra blank line after every root commit line
>> (possibly except the last one)? That should make it plenty easy to see
>> where the root commits are in --oneline mode. I think it would actually
>> be easier to spot at a glance than replacing `*` with `x` because it
>> creates a gap in all columns of the output, rather than only in column
>> 1. Also, this is very subjective but I think it looks kind of ugly to
>> use "x" :P
>
> I agree to all of the above, including the ugliness of 'x' ;-)
>
> A "blank" may however be hard to spot, if the range is limited,
> though. For example,
>
> $ git log --graph --oneline a4..
> * HEAD
> /* a1
> | * a2
> | * a3
> * b1
> * b2
> * b3
>
> where "a4", which is a root, is the sole parent of "a3" and HEAD is
> a merge between "a1" and "b1" might produce something like this,
> while we may get this from the same history, when shown unlimited:
>
> $ git log --graph --oneline
> * HEAD
> /* a1
> | * a2
> | * a3
> | * a4
> |
> * b1
> * b2
> * b3
>
> A divider line might make it visually a lot more strong, i.e.
>
> $ git log --graph --oneline
> * HEAD
> /* a1
> | * a2
> | * a3
> | * a4
> | ~~~~~~~~~~~~~~~~~~~~~~~
> * b1
> * b2
> * b3
>
> but I am not sure if it is too distracting.
I would be fine with that, fwiw. We can also turn it on and off with a
config option if people really don't like it, I suppose...
-Keshav
next prev parent reply other threads:[~2013-10-28 17:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 16:07 [PATCH] graph.c: visual difference on subsequent series Milton Soares Filho
2013-10-25 17:13 ` Junio C Hamano
2013-10-25 20:49 ` Milton Soares Filho
2013-10-26 2:37 ` Keshav Kini
2013-10-28 15:41 ` Junio C Hamano
2013-10-28 16:59 ` Keshav Kini [this message]
2013-10-28 17:18 ` Milton Soares Filho
2013-10-28 17:39 ` Junio C Hamano
2013-12-20 20:22 ` [RFH/PATCH] graph: give an extra gap after showing root commit Junio C Hamano
2013-12-20 22:03 ` Junio C Hamano
2014-01-03 20:16 ` Thomas Rast
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 20:51 [PATCH] graph.c: visual difference on subsequent series Milton Soares Filho
2014-11-10 13:33 Antoine Beaupré
2015-07-27 19:37 ` Antoine Beaupré
2015-07-27 20:17 ` Junio C Hamano
2015-09-03 8:04 ` Michael J Gruber
2015-09-03 17:13 ` Junio C Hamano
2015-09-04 14:07 ` Michael J Gruber
2015-09-04 16:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvrljpq4.fsf@gmail.com \
--to=keshav.kini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=milton.soares.filho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).