From: Kyle Meyer <kyle@kyleam.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] t1400: modernize style
Date: Tue, 21 Mar 2017 21:58:26 -0400 [thread overview]
Message-ID: <87fui6kr7h.fsf@kyleam.com> (raw)
In-Reply-To: <20170321020155.dx5juulntg5k6fpr@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> On Mon, Mar 20, 2017 at 08:56:11PM -0400, Kyle Meyer wrote:
[...]
>> * moving the here-documents for log creation into the following
>> tests, but I don't think it's worth it because it makes already
>> long lines even longer.
>
> Yeah, they're quite long. Probably something like:
>
> # arguments: <from> <to> <time> <msg>
> reflog () {
> printf '%s %s %s <%s> %s +0000\t%s' \
> "$1" "$2" \
> "$GIT_COMMITTER_NAME" "$GIT_COMMITTER_EMAIL" \
> "$3" "$4"
> }
>
> test_expect_success 'verify $m log' '
> {
> reflog $Z $A 1117150200 "Initial Creation" &&
> reflog $A $B 1117150260 "Switch" &&
> reflog $B $A 1117150860 &&
> } >expect &&
> test_cmp expect .git/logs/$m
> '
>
> wouldn't be too bad. Or maybe it's worse, because the actual format is
> all tangled up in that printf statement. ;)
>
> I'm OK with it either way.
Heh, I didn't consider that option. I suppose I'll stick with the
here-document for now because, to my eyes, it seems a bit easier to
read.
--
Kyle
prev parent reply other threads:[~2017-03-22 1:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 0:56 [PATCH 0/5] t1400: modernize style Kyle Meyer
2017-03-21 0:56 ` [PATCH 1/5] t1400: rename test descriptions to be unique Kyle Meyer
2017-03-21 1:38 ` Jeff King
2017-03-21 0:56 ` [PATCH 2/5] t1400: set core.logAllRefUpdates in "logged by touch" tests Kyle Meyer
2017-03-21 1:49 ` Jeff King
2017-03-22 1:57 ` Kyle Meyer
2017-03-21 0:56 ` [PATCH 3/5] t1400: use test_path_is_* helpers Kyle Meyer
2017-03-21 1:51 ` Jeff King
2017-03-21 0:56 ` [PATCH 4/5] t1400: remove a set of unused output files Kyle Meyer
2017-03-21 1:51 ` Jeff King
2017-03-21 0:56 ` [PATCH 5/5] t1400: use test_when_finished for cleanup Kyle Meyer
2017-03-21 1:53 ` Jeff King
2017-03-21 2:01 ` [PATCH 0/5] t1400: modernize style Jeff King
2017-03-21 17:51 ` Junio C Hamano
2017-03-22 1:58 ` Kyle Meyer
2017-03-22 1:58 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fui6kr7h.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).