From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Daniel Jacques <dnj@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v4 1/4] Makefile: generate Perl header from template file
Date: Fri, 08 Dec 2017 22:15:59 +0100 [thread overview]
Message-ID: <87fu8kex9s.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CACBZZX4JKhprF-3L3===XOBJ3Gp7W2xbeJshZFAmnjwevs0JoQ@mail.gmail.com>
On Wed, Dec 06 2017, Ævar Arnfjörð Bjarmason jotted:
> On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques <dnj@google.com> wrote:
>> On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>> Johannes Sixt <j6t@kdbg.org> writes:
>>>
>>> > The updated series works for me now. Nevertheless, I suggest to squash
>>> > in the following change to protect against IFS and globbing characters in
>>> > $INSTLIBDIR.
>>>
>>> Yeah, that is very sensible.
>>>
>>> > diff --git a/Makefile b/Makefile
>>> > index 7ac4458f11..08c78a1a63 100644
>>> > --- a/Makefile
>>> > +++ b/Makefile
>>> > @@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
>>> > INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
>>> > INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
>>> > sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
>>> > - -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
>>> > + -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
>>> > -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
>>> > -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
>>> > $< >$@+ && \
>>
>> Sounds good; I'll apply that to my working patch and include it in my
>> next ("v5") submission, which is currently blocked pending avarab@'s Perl
>> Makefile changes:
>> https://public-inbox.org/git/20171129195430.10069-1-avarab@gmail.com/T/#t
>
> Thanks, FWIW I'll send another version of that at the end of the week
> or so, I'm waiting to see if there's any more comments on it to reduce
> list churn.
Sorry, I got this conflated with my sha1collisiondetection series, I
have nothing new to send out.
It seems everyone's happy with the version of my v2 (with Junio's
<xmqqzi6ympi9.fsf@gitster.mtv.corp.google.com> on top) from this series,
so it's just a matter of waiting.
next prev parent reply other threads:[~2017-12-08 21:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 15:56 [PATCH v4 0/4] RUNTIME_PREFIX relocatable Git Dan Jacques
2017-11-29 15:56 ` [PATCH v4 1/4] Makefile: generate Perl header from template file Dan Jacques
2017-12-01 16:59 ` Johannes Sixt
2017-12-01 17:13 ` Johannes Schindelin
2017-12-01 17:25 ` Johannes Sixt
2017-12-01 18:18 ` Dan Jacques
2017-12-01 18:52 ` Andreas Schwab
2017-12-05 20:54 ` Johannes Sixt
2017-12-05 21:17 ` Junio C Hamano
2017-12-05 21:26 ` Dan Jacques
2017-12-05 21:35 ` Junio C Hamano
2017-12-06 18:25 ` Johannes Sixt
2017-12-06 18:47 ` Junio C Hamano
2017-12-06 18:56 ` Daniel Jacques
2017-12-06 19:01 ` Ævar Arnfjörð Bjarmason
2017-12-08 21:15 ` Ævar Arnfjörð Bjarmason [this message]
2018-04-23 23:23 ` [PATCH dj/runtime-prefix 0/2] Handle $IFS in $INSTLIBDIR Jonathan Nieder
2018-04-23 23:24 ` [PATCH 1/2] Makefile: remove unused @@PERLLIBDIR@@ substitution variable Jonathan Nieder
2018-04-24 2:11 ` Junio C Hamano
2018-04-23 23:25 ` [PATCH 2/2] Makefile: quote $INSTLIBDIR when passing it to sed Jonathan Nieder
2018-04-24 0:53 ` Junio C Hamano
2018-04-24 2:18 ` [PATCH 2/2 v2] " Jonathan Nieder
2018-04-24 2:56 ` Daniel Jacques
2017-12-03 5:26 ` [PATCH v4 1/4] Makefile: generate Perl header from template file Junio C Hamano
2017-12-03 9:26 ` Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 2/4] Makefile: add support for "perllibdir" Dan Jacques
2017-11-29 20:04 ` Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 3/4] Makefile: add Perl runtime prefix support Dan Jacques
2017-11-29 21:00 ` Ævar Arnfjörð Bjarmason
2017-12-02 15:47 ` [PATCH v4 3/4] RUNTIME_PREFIX relocatable Git Dan Jacques
2017-11-29 21:04 ` [PATCH v4 3/4] Makefile: add Perl runtime prefix support Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems Dan Jacques
2017-11-29 21:12 ` [PATCH v4 0/4] RUNTIME_PREFIX relocatable Git Ævar Arnfjörð Bjarmason
2017-11-29 22:38 ` Dan Jacques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu8kex9s.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).