From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BFA861F8C6 for ; Tue, 7 Sep 2021 16:05:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233172AbhIGQGL (ORCPT ); Tue, 7 Sep 2021 12:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242730AbhIGQFH (ORCPT ); Tue, 7 Sep 2021 12:05:07 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CEA5C061757 for ; Tue, 7 Sep 2021 09:03:31 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id t19so20650079ejr.8 for ; Tue, 07 Sep 2021 09:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=HgYN4nLRhP2yEEgNkYxetmAEndwiU3k9dJiov4fzN+g=; b=Ns84FQ77PiWlXa/XuyaO+T1XQ5g8VpQo3/OSmq4DPXb+dpMO3fNe7qKZdebJ63HuyK poKYfGLw8mSphzl2SAu+3Dv84GPE5hyGLjwVejQtJF++iOEZGD/8dS6ORJMlacd6rm0O PtS25cfoqL9AAV5ziqI+RJwkQ4n/yDejKSlEgU/DVn/dpMIwFL9rWIhWd9YyifGqQZhR Lyzw71RyWaBczTzSmKs+GP/RbMSPw+46Z1EKP3BDgGVDu7gBmazv2tez8n0KlyOl0TLa M7/Ab/+uvc/PAjrwuA8plIhkjrIQD4HvG83JBufPOkOpGK4WGrkM2RJviJcs+Br6xCaP 5Uug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=HgYN4nLRhP2yEEgNkYxetmAEndwiU3k9dJiov4fzN+g=; b=W9VZA3g4iwfWLHFnzfP0I/IMIugesLZwUgFEY4zi9g5Un03FX/kYec3abzp3c9uI2u lrF6CflTH1mhpG3/QHGw0HJZgNuoQbyQUZZjaxvz4vfzVCKdaYJmFzsoie5I1kDhRYfx nZeqkdT63OdR3/rbUDk9nC0HI/DX22VJoT61NeIKrgBIf9CMi8SEthNhvvdG5+dFLnfG L2t6o6IMdC2h6ZQ933Z/wglJhjUzt2I+LkA9MeH/gH/5PrfRnOcuyDaJTWfZmvnzqJbv LKeI50JCw9Db42swoFRoTCGr9DmFrNTDVQkUY/Cvdv2O1fPBHoxnQPY0nHPivLQDLA2k 36/A== X-Gm-Message-State: AOAM530/K9ZfNSHjTRZX+0pGD0IbqAGdpqcvStuRxm6G1XZONaEHSrT4 kXlLEfsPrr3cZFwm3YvuTtY4oYpZYrRJ6A== X-Google-Smtp-Source: ABdhPJwXpPttkxEAAP29d7z+SDl8bUpmzF9bb2KSrFPiWigQMUR2nzO3XMtwkd7kV7628HFSbYtikg== X-Received: by 2002:a17:906:34ca:: with SMTP id h10mr19462801ejb.137.1631030609920; Tue, 07 Sep 2021 09:03:29 -0700 (PDT) Received: from evledraar (j120189.upc-j.chello.nl. [24.132.120.189]) by smtp.gmail.com with ESMTPSA id r22sm5740431ejj.91.2021.09.07.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 09:03:29 -0700 (PDT) From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Han-Wen Nienhuys Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org, Taylor Blau , Han-Wen Nienhuys Subject: Re: [PATCH v2 2/5] test-ref-store: tweaks to for-each-reflog-ent format Date: Tue, 07 Sep 2021 17:53:07 +0200 References: <11b296a55e9e450575c64ade1a2cb93a1886b9da.1630947142.git.gitgitgadget@gmail.com> <878s09nxh1.fsf@evledraar.gmail.com> User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.0 In-reply-to: Message-ID: <87fsugl6en.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 07 2021, Han-Wen Nienhuys wrote: > On Tue, Sep 7, 2021 at 12:35 AM =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > wrote: >> > - printf("%s %s %s %"PRItime" %d %s\n", >> > - oid_to_hex(old_oid), oid_to_hex(new_oid), >> > - committer, timestamp, tz, msg); >> > + printf("%s %s %s %" PRItime " %+05d\t%s\n", oid_to_hex(old_oid), >> > + oid_to_hex(new_oid), committer, timestamp, tz, msg); >> >> Nit: Would be a more readable diff if this wasn't a >> line-wrap-while-at-it change in addition to changing the format string. >> >> I.e. the last 4x parameters aren't changed, so leaving them on their own >> line & just changing the string & the two oid_to_hex()... > > This is clang-format's output, and the new code takes up less lines verti= cally. > > If you think this is really, really important, I can change it, but I > think it's a better use of everyone's time to leave mechanical tasks > (like formatting) to the machines. It's not "really, really important" or even "really important", just notes while reading the series. Patches are read N times, including during review. Since humans read formatting changes, it's in general are not something we can leave to machines. We're after all looking at the patch on-list, not diffing two versions of the generated machine code, or of clang-format's output. I don't think the intent of the clang-format target is to run it before patch submission, but to serve as input on suggested formatting changes. If on master you run: git ls-files '*.[ch]' -z | xargs -n 1 -0 clang-format -i You'll get: 631 files changed, 48246 insertions(+), 45061 deletions(-) Which I think speaks for itself in the likelyhood that "git-clang-format" is going to inject unnecessary churn into submitted patches. I think this case is quite small and not worth a re-roll.