* [PATCH] git-remote.txt: fix typo
@ 2007-11-13 18:17 Sergei Organov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Organov @ 2007-11-13 18:17 UTC (permalink / raw
To: git; +Cc: gitster
Signed-off-by: Sergei Organov <osv@javad.com>
---
Documentation/git-remote.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
index 027ba11..0da8704 100644
--- a/Documentation/git-remote.txt
+++ b/Documentation/git-remote.txt
@@ -79,7 +79,7 @@ caution.
Fetch updates for a named set of remotes in the repository as defined by
remotes.<group>. If a named group is not specified on the command line,
the configuration parameter remotes.default will get used; if
-remotes.default is not defined, all remotes which do not the
+remotes.default is not defined, all remotes which do not have the
configuration parameter remote.<name>.skipDefaultUpdate set to true will
be updated. (See gitlink:git-config[1]).
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] git-remote.txt: fix typo
@ 2024-02-21 8:35 Jakub Wilk
2024-02-21 18:18 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Wilk @ 2024-02-21 8:35 UTC (permalink / raw
To: git; +Cc: Junio C Hamano, Abhradeep Chakraborty
Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
---
Documentation/git-remote.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
index 1dec314834..932a5c3ea4 100644
--- a/Documentation/git-remote.txt
+++ b/Documentation/git-remote.txt
@@ -35,7 +35,7 @@ OPTIONS
-v::
--verbose::
Be a little more verbose and show remote url after name.
- For promisor remotes, also show which filter (`blob:none` etc.)
+ For promisor remotes, also show which filters (`blob:none` etc.)
are configured.
NOTE: This must be placed between `remote` and subcommand.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-remote.txt: fix typo
2024-02-21 8:35 Jakub Wilk
@ 2024-02-21 18:18 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2024-02-21 18:18 UTC (permalink / raw
To: Jakub Wilk; +Cc: git, Abhradeep Chakraborty
Jakub Wilk <jwilk@jwilk.net> writes:
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
> ---
> Documentation/git-remote.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
> index 1dec314834..932a5c3ea4 100644
> --- a/Documentation/git-remote.txt
> +++ b/Documentation/git-remote.txt
> @@ -35,7 +35,7 @@ OPTIONS
> -v::
> --verbose::
> Be a little more verbose and show remote url after name.
> - For promisor remotes, also show which filter (`blob:none` etc.)
> + For promisor remotes, also show which filters (`blob:none` etc.)
> are configured.
> NOTE: This must be placed between `remote` and subcommand.
When you give more than one filters to "git clone", they are used to
create a single "combined" filter, so strictly speaking, "also show
which filter is configured" is a grammatically valid that might be
more technically correct. E.g. the user may see
$ git clone --filter=blob:none --filter=tree:2 $there sample-repo
$ git -C sample-repo remote -v show
origin ... (fetch) [combine:blob:none+tree:2]
origin ... (push)
in the output. It may not be a bad idea to update the code to show
the filter information in a way that is more clear that we are
seeing a list of filters (perhaps showing the above as "[blob:none
tree:2]" might be a good starting point, as a totally separate topic
(#leftoverbits).
After taking your patch as-is, that is. In user's mind, they
consider they gave two filters, and making a single combined filter
is something Git did without being asked for its own convenience,
so "which filters are configured" is, while it may be technically
less correct, much closer to what the end-user perceives.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-21 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-13 18:17 [PATCH] git-remote.txt: fix typo Sergei Organov
-- strict thread matches above, loose matches on Subject: below --
2024-02-21 8:35 Jakub Wilk
2024-02-21 18:18 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).