From: greened@obbligato.org (David A. Greene)
To: ELI <eliptus@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Subtree Split Includes Commits Outside Prefix Directory
Date: Sat, 21 May 2016 18:06:52 -0500 [thread overview]
Message-ID: <87eg8vovsj.fsf@waller.obbligato.org> (raw)
In-Reply-To: <CAKU2X8bAXmVfJz9P7d3k-_d12sjyrzWt+kJCGj8V6fTDAjsFog@mail.gmail.com> (ELI's message of "Fri, 22 Apr 2016 11:38:35 -0700")
ELI <eliptus@gmail.com> writes:
> I then reviewed the commit history of contrib/subtree/git-subtree.sh
> and determined that the last successful subtree push was performed
> prior to the integration of this change:
> https://git.kernel.org/cgit/git/git.git/commit/contrib/subtree/git-subtree.sh?id=933cfeb90b5d03b4096db6d60494a6eedea25d03
>
> As a next step, I reversed that patch on my local install of git
> subtree, and the result was a successful subtree push.
So you're saying that this patch caused a regression?
> Unfortunately, I have not yet reproduced this with a test main project
> and subprojects, and I cannot make the project I observed it in
> public.
I very much want to see a testcase for this. I'm planning to
fundamentally rewrite the split code this year and want to make sure it
covers everything it does now and fixes a few bugs that have been
exposed lately.
It's tough to revert that patch since it fixed a problem for someone and
we don't have a testcase demonstrating the problem you encountered. Not
saying your problem isn't important but we need to understand it and
have a way to flag it before fixing or hiding it with a revert of the
above patch.
-David
next prev parent reply other threads:[~2016-05-21 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 18:38 Subtree Split Includes Commits Outside Prefix Directory ELI
2016-05-21 23:06 ` David A. Greene [this message]
[not found] ` <CAKU2X8ZTf6_ptGkD4na+j5MPeD=yCKUTpK6VT2Ye87Ffs_KdrA@mail.gmail.com>
2016-06-24 2:32 ` ELI
2016-08-30 5:12 ` ELI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg8vovsj.fsf@waller.obbligato.org \
--to=greened@obbligato.org \
--cc=eliptus@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).