From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] read-cache: write all indexes with the same permissions
Date: Sun, 18 Nov 2018 13:03:39 +0100 [thread overview]
Message-ID: <87efbi1tk4.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqsgzyg8ux.fsf@gitster-ct.c.googlers.com>
On Sun, Nov 18 2018, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Do you mean that you don't agree that following should always create
>> both "foo" and e.g. ".git/refs/heads/master" with the same 644
>> (-rw-rw-r--) mode:
>>
>> (
>> rm -rf /tmp/repo &&
>> umask 022 &&
>> git init /tmp/repo &&
>> cd /tmp/repo &&
>> echo hi >foo &&
>> git add foo &&
>> git commit -m"first"
>> )
>>
>> To me what we should do with the standard umask and what
>> core.sharedRepository are for are completely different things.
>
> Ahh, of course. If you put it that way, I do agree that it gives us
> a valid use case where core.sharedRepository is false and the umask
> of repository owner is set to 022 (or anything that does not allow
> write to group or others, and allows read to group) to let group
> members only peek but not touch the contents of the repository.
>
> I think I was distracted by the mention of ore.sharedRepository in
> the proposed log message.
Thanks. I'll submit a v3 with a less confusing commit message.
next prev parent reply other threads:[~2018-11-18 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 17:31 [PATCH v2] read-cache: write all indexes with the same permissions Christian Couder
2018-11-16 18:02 ` Duy Nguyen
2018-11-16 19:10 ` Christian Couder
2018-11-16 19:16 ` Duy Nguyen
2018-11-16 18:29 ` SZEDER Gábor
2018-11-16 19:25 ` Ævar Arnfjörð Bjarmason
2018-11-16 19:25 ` Christian Couder
2018-11-17 8:57 ` Junio C Hamano
2018-11-17 12:24 ` SZEDER Gábor
2018-11-17 9:29 ` Junio C Hamano
2018-11-17 11:19 ` Christian Couder
2018-11-17 13:05 ` Junio C Hamano
2018-11-17 21:14 ` Ævar Arnfjörð Bjarmason
2018-11-18 7:09 ` Junio C Hamano
2018-11-18 12:03 ` Ævar Arnfjörð Bjarmason [this message]
2018-11-18 19:04 ` [PATCH v3] read-cache: make the split index obey umask settings Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efbi1tk4.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).