From: David Kastrup <dak@gnu.org>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Nemina Amarasinghe <neminaa@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c
Date: Mon, 10 Mar 2014 09:36:31 +0100 [thread overview]
Message-ID: <87d2hua1rk.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <vpqd2huihsc.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 10 Mar 2014 09:23:15 +0100")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Nemina Amarasinghe <neminaa@gmail.com> writes:
>
>> Nemina Amarasinghe <neminaa <at> gmail.com> writes:
>>
>> Sorry for the first patch. Something went wrong. This is the correct one
>
> Please, re-read Documentation/SubmittingPatches. In short, don't inline
> patch headers and don't forget the sign-off.
>
>> Subject: [PATCH] simplified the chain if() statements of
>> install_brach_config() function in branch.c
>
> Keep the subject line short (ideally <50 characters), and avoid past
> tense. We usually use imperative (the patch asks the codebase to
> refactor itself => "simplify if statements ...". We usually prefix the
> subject line with the place/subsystem where the change is done =>
> "branch.c: simplify if ...".
>
>> - else if (!remote_is_branch && origin)
>> - printf_ln(rebasing ?
>> - _("Branch %s set up to track remote ref %s by rebasing.") :
>> - _("Branch %s set up to track remote ref %s."),
>> - local, remote);
>> - else if (!remote_is_branch && !origin)
>> + else if (!remote_is_branch && (origin || !origin))
>
> Is it me, or is (origin || !origin) a tautology?
Since it _is_ you, that question is a tautology because of its first
part already. But the second one would be just as good.
--
David Kastrup
next prev parent reply other threads:[~2014-03-10 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 7:39 [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c Nemina Amarasinghe
2014-03-10 7:58 ` Nemina Amarasinghe
2014-03-10 8:23 ` Matthieu Moy
2014-03-10 8:36 ` David Kastrup [this message]
2014-03-10 8:51 ` Nemina Amarasinghe
2014-03-10 9:05 ` Matthieu Moy
2014-03-10 9:08 ` David Kastrup
2014-03-10 9:15 ` Nemina Amarasinghe
2014-03-10 9:27 ` David Kastrup
2014-03-10 20:46 ` Eric Sunshine
2014-03-11 6:30 ` Nemina Amarasinghe
2014-03-11 8:06 ` Eric Sunshine
2014-03-11 7:16 ` [PATCH][GSoC]simplified branch.c:install_branch_config() if() statement Nemina Amarasinghe
2014-03-11 8:11 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hua1rk.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=neminaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).