From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Keith Smiley <keithbsmiley@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make stashing nothing exit 1
Date: Sat, 23 Mar 2019 08:54:37 +0100 [thread overview]
Message-ID: <87d0mic9fm.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <01020169a7ad6af3-ad50e2d1-19fb-46eb-b397-759f8d579e8b-000000@eu-west-1.amazonses.com>
On Sat, Mar 23 2019, Keith Smiley wrote:
> In the case there are no files to stash, but the user asked to stash, we
> should exit 1 since the stashing failed.
> ---
> git-stash.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-stash.sh b/git-stash.sh
> index 789ce2f41d4a3..ca362b1a31277 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -318,7 +318,7 @@ push_stash () {
> if no_changes "$@"
> then
> say "$(gettext "No local changes to save")"
> - exit 0
> + exit 1
> fi
>
> git reflog exists $ref_stash ||
Thanks for contributing, some points:
* stash is currently (in the 'next' branch) being rewritten in C. It's
a better move at this point to patch that version, this code is about
to be deleted.
* This is missing a corresponding test, and skimming the stash manpage
we should document how these exit codes are supposed to act.
* Shouldn't we do this consistently across all the other sub-commands?
Trying some of them seems 'push' may be the odd one out, but maybe
I've missed some (and this would/should be covered by
tests). I.e. some single test that does a bunch of ops with no
entries / nothing to stash and asserts exit codes.
next prev parent reply other threads:[~2019-03-23 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 23:12 [PATCH] Make stashing nothing exit 1 Keith Smiley
2019-03-23 7:54 ` Ævar Arnfjörð Bjarmason [this message]
2019-03-24 3:37 ` Eric Sunshine
2019-03-25 15:29 ` Johannes Schindelin
2020-04-12 13:08 ` Maxim Mazurok
2019-03-24 12:42 ` Junio C Hamano
2019-05-22 23:57 ` Maksim Odnoletkov
2019-05-23 0:23 ` Ævar Arnfjörð Bjarmason
2019-05-23 6:14 ` Johannes Sixt
2019-05-23 9:49 ` Maksim Odnoletkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0mic9fm.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=keithbsmiley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).