git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"Andrzej Hunt" <ajrhunt@google.com>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH 00/10] leak tests: mark more tests as passing
Date: Tue, 12 Oct 2021 15:40:04 +0200	[thread overview]
Message-ID: <87czoajr35.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CABPp-BEpCa7dxYqe2R82N_eVzx5e17C2w+d1zD9XWzyEXCDbPw@mail.gmail.com>


On Wed, Oct 06 2021, Elijah Newren wrote:

> On Wed, Oct 6, 2021 at 2:50 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>
>> This goes on top of ab/sanitize-leak-ci, in that topic I introduced a
>> "linux-leaks" job that runs in CI and checks that we don't have
>> SANITIZE=leak regressions, but it just marked one test file as passing
>> under that mode.
>>
>> That was out of an abundance of caution, and to not conflate any
>> potential failures with the mode itself.
>>
>> This series marks up a lot of tests as passing, ensuring that they
>> won't regress when it comes to memory leaks.
>
> I like the series.  It does have the potential to annoy folks who want
> to add additional tests which make use of git commands outside the
> area they are modifying and which happen to have pre-existing leaks.
> But, I think in such cases, they could just remove the
> TEST_PASSES_SANITIZE_LEAK=true and mention it in their commit message.
> And when the checks fail because of a git command someone is
> modifying, then we get useful early signal and the author can address
> the problem.

Yes there's a definite chance for annoyance while the common leak fixes
I've got planned are cooking, i.e. as we've discussed elsewhere "git
log" and "git checkout" among others leak in almost any invocation you
cank think of, so if you add a new test that steps on those landmines
(including via test_commit!) you'll run afoul of this.

But I'm hoping to have those common cases sorted out SOON, so hopefully
any problems with this are short lived.

Just FWIW if this does happen you probably won't and shouldn't need to
remove the TEST_PASSES_SANITIZE_LEAK=true entirely, it should be enough
to make the specific test use "!SANITIZE_LEAK" as a prerequisite. See
956d2e4639b (tests: add a test mode for SANITIZE=leak, run it in CI,
2021-09-23).

Well, that can also get annoying if e.g. you want to add a "test_commit"
to a short test that has an existing setup (you'd need to split up the
"setup" phase).

Anyway, will re-roll, just FYI^
 


  parent reply	other threads:[~2021-10-12 13:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  9:50 [PATCH 00/10] leak tests: mark more tests as passing Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 01/10] leak tests: run various built-in tests in t00*.sh SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-07 22:33   ` Junio C Hamano
2021-10-06  9:50 ` [PATCH 02/10] leak tests: run various "test-tool" " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 03/10] leak tests: mark t0000-init.sh as passing with SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-07 22:35   ` Junio C Hamano
2021-10-12 13:39     ` Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 04/10] leak tests: mark all ls-tree tests " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 05/10] leak tests: mark all trace2 " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 06/10] leak tests: mark all checkout-index " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 07/10] leak tests: mark some ls-files " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 08/10] leak tests: mark some read-tree " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 09/10] leak tests: mark various "generic" " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 10/10] leak tests: mark some misc " Ævar Arnfjörð Bjarmason
2021-10-06 16:26 ` [PATCH 00/10] leak tests: mark more tests as passing Elijah Newren
2021-10-07 22:38   ` Junio C Hamano
2021-10-12 13:40   ` Ævar Arnfjörð Bjarmason [this message]
2021-10-12 13:56 ` [PATCH v2 0/9] " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 1/9] leak tests: run various built-in tests in t00*.sh SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 2/9] leak tests: run various "test-tool" " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 3/9] leak tests: mark all ls-tree tests as passing with SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 4/9] leak tests: mark all trace2 " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 5/9] leak tests: mark all checkout-index " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 6/9] leak tests: mark some ls-files " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 7/9] leak tests: mark some read-tree " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 8/9] leak tests: mark various "generic" " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 9/9] leak tests: mark some misc " Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czoajr35.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=ajrhunt@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).