From: "Ævar Arnfjörð Bjarmason" <email@example.com> To: Felipe Contreras <firstname.lastname@example.org> Cc: email@example.com, "Jeff King" <firstname.lastname@example.org>, "Martin Ågren" <email@example.com>, "brian m . carlson" <firstname.lastname@example.org>, "Junio C Hamano" <email@example.com> Subject: Re: [PATCH 2/8] doc: add an asciidoc helper Date: Thu, 13 May 2021 17:17:33 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On Wed, May 12 2021, Felipe Contreras wrote: > The hacks to deal with interrupted builds is scattered throughout the > Makefile, but not everywhere (it's not done for techical/ and articles). > > It originally comes from f9dae0d3e6 (Documentation/Makefile: fix > interrupted builds of user-manual.xml, 2010-04-21), however, that > description is not correct. > > asciidoc does actually remove the output file in case of an exception, > but there was a bug that handled keyboard interruptions through a > different path, and thus in that particular case the file is not > removed. > > We shouldn't overly complicate the Makefile due to bugs in asciidoc. > > In order to keep the Makefile clean this commit creates an asciidoc > wrapper that does the job of tracking the intermediary output. > > Once asciidoc is fixed this helper can be safely removed and there would > be minimal changes elsewhere. > > It's written for bash, but could easily be modified for something more > portable. Both this and your first patch could just be made to use the .DELETE_ON_ERROR flag instead, although that's a bigger change. I had this and a related series for that recently: https://lore.kernel.org/git/patch-4.6-2ff6359c273-20210329T161723Zfirstname.lastname@example.org/ I don't think anyone had an objection to using that, I didn't pursue it because I was trying to make (among other things) AIX development less annoying, but Junio didn't like the -o $@+ && mv $@+ $@ pattern for object files, so I gave up on pursuing it. But if you're trying to address this "maybe it errors" issue then .DELETE_ON_ERROR is a better solution. I think if we use that we should also undo your changes to use "-o file" and instead pipe to the file ourselves, otherwise we'll probably have cases where the program that fails and GNU make will race to delete the file (but I haven't tested that case).
next prev parent reply other threads:[~2021-05-13 15:20 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-12 22:27 [PATCH 0/8] doc: asciidoc cleanups Felipe Contreras 2021-05-12 22:27 ` [PATCH 1/8] doc: standardize asciidoc calls Felipe Contreras 2021-05-12 22:27 ` [PATCH 2/8] doc: add an asciidoc helper Felipe Contreras 2021-05-13 15:17 ` Ævar Arnfjörð Bjarmason [this message] 2021-05-13 19:33 ` Felipe Contreras 2021-05-13 21:43 ` Junio C Hamano 2021-05-12 22:27 ` [PATCH 3/8] doc: disable asciidoc-helper for asciidoctor Felipe Contreras 2021-05-12 22:27 ` [PATCH 4/8] doc: simplify the handling of interruptions Felipe Contreras 2021-05-13 5:19 ` Junio C Hamano 2021-05-13 6:10 ` Felipe Contreras 2021-05-12 22:28 ` [PATCH 5/8] doc: remove redundant rm Felipe Contreras 2021-05-13 15:22 ` Ævar Arnfjörð Bjarmason 2021-05-13 18:58 ` Felipe Contreras 2021-05-12 22:28 ` [PATCH 6/8] doc: refactor common dependencies Felipe Contreras 2021-05-12 22:28 ` [PATCH 7/8] doc: improve asciidoc dependencies Felipe Contreras 2021-05-13 17:43 ` Martin Ågren 2021-05-12 22:28 ` [PATCH 8/8] doc: join xml and man rules Felipe Contreras 2021-05-13 11:02 ` Martin Ågren 2021-05-13 11:15 ` Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/8] doc: add an asciidoc helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git