list mirror (unofficial, one of many)
 help / color / Atom feed
From: Pat Thoyts <>
Cc: Dejan Ribič <>, Git ML <>
Subject: Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.
Date: Mon, 31 Oct 2011 08:56:31 +0000
Message-ID: <> (raw)
In-Reply-To: <>

Erik Faye-Lund <> writes:

>Thanks for re-posting inline and with a sign-off. But there's still a
>few minor nits:
>2011/10/30 Dejan Ribič <>:
>> "succeded" changed to "succeeded".
>We write commit messages in imperative mood, so this should be
>something like 'change "succeded" to "succeeded"' instead. This is
>documented in Documentation/SubmittingPatches.
>> modified:   git-gui/lib/sshkey.tcl
>We don't normally include a list of changed files in the commit
>message; the diffstat already provides that information.

The change is fine so I've applied this to the git-gui repository with a
fixed commit message. Thank you.

git-gui is hosted separately and merged into git-core at intervals so
the development version of git-gui is in fact hosted at 
git:// although patches against the git-core
version seldom pose a problem to apply and are gratefully received.
(git am -p2 usually fixes them).

Pat Thoyts                  
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <n>
2011-10-30 17:18 ` Dejan Ribič
2011-10-30 23:57   ` Erik Faye-Lund
2011-10-31  8:56     ` Pat Thoyts [this message]
2017-10-11 18:06 ` [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-11 18:37 ` Takahito Ogawa
2017-10-11 19:09   ` Thomas Gummerer
2017-10-11 19:12     ` Thomas Gummerer
2017-10-11 20:01 ` Takahito Ogawa

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone public-inbox