From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
Derrick Stolee <dstolee@microsoft.com>, Eric Wong <e@80x24.org>
Subject: Re: What's cooking in git.git (Apr 2019, #03; Tue, 16)
Date: Wed, 17 Apr 2019 12:22:54 +0200 [thread overview]
Message-ID: <87a7gpaq2p.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <adb4a578-9bc6-f017-5817-cd045dcb0a32@gmail.com>
On Wed, Apr 17 2019, Phillip Wood wrote:
> On 16/04/2019 15:51, Ævar Arnfjörð Bjarmason wrote:
>>
>> On Tue, Apr 16 2019, Junio C Hamano wrote:
>>
>>> * pw/rebase-i-internal-rfc (2019-03-21) 12 commits
>>> - rebase -i: run without forking rebase--interactive
>>> - rebase: use a common action enum
>>> - rebase -i: use struct rebase_options in do_interactive_rebase()
>>> - rebase -i: use struct rebase_options to parse args
>>> - rebase -i: use struct object_id for squash_onto
>>> - rebase -i: use struct commit when parsing options
>>> - rebase -i: remove duplication
>>> - rebase -i: combine rebase--interactive.c with rebase.c
>>> - rebase: use OPT_RERERE_AUTOUPDATE()
>>> - rebase: rename write_basic_state()
>>> - sequencer: always discard index after checkout
>>> - Merge branch 'ag/sequencer-reduce-rewriting-todo' into pw/rebase-i-internal-rfc
>>> (this branch uses ag/sequencer-reduce-rewriting-todo.)
>>>
>>> The internal implementation of "git rebase -i" has been updated to
>>> avoid forking a separate "rebase--interactive" process.
>>>
>>> Comments? Is this ready?
>>
>> I gave this some stress testing/review in your infra, works for me so
>> far, and a good performance improvement.
>>
>> My only problem with it is that the commit message doesn't note just
>> quite how awesome it is, but I can live with that :)
>
> Thanks for testing this, I'll send a re-roll that mentions the
> performance improvement. I'm still surprised by it, are you seeing an
> improvement in production as well as on the perf test you mentioned
> before? I wonder if some of the improvement is due to
> ag/sequencer-reduce-rewriting-todo if that wasn't in master when you
> ran the benchmarks but I haven't had time to investigate.
Just the perf tests. I don't think it'll have much noticeable impact on
a typical rebase, but everything helps...
next prev parent reply other threads:[~2019-04-17 10:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 13:19 What's cooking in git.git (Apr 2019, #03; Tue, 16) Junio C Hamano
2019-04-16 14:51 ` Ævar Arnfjörð Bjarmason
2019-04-16 15:26 ` Junio C Hamano
2019-04-17 7:18 ` Ævar Arnfjörð Bjarmason
2019-04-18 0:12 ` Junio C Hamano
2019-04-17 9:33 ` Duy Nguyen
2019-04-17 9:52 ` Phillip Wood
2019-04-17 10:22 ` Ævar Arnfjörð Bjarmason [this message]
2019-04-16 15:27 ` Ben Peart
2019-04-17 2:37 ` Junio C Hamano
2019-04-16 16:25 ` Stalled ds/ branches (was What's cooking in git.git (Apr 2019, #03; Tue, 16)) Derrick Stolee
2019-04-16 17:32 ` jt/clone-server-option " Jonathan Tan
2019-04-17 2:39 ` Junio C Hamano
2019-04-17 16:18 ` Jonathan Tan
2019-04-18 1:51 ` Junio C Hamano
2019-04-17 2:37 ` What's cooking in git.git (Apr 2019, #03; Tue, 16) Taylor Blau
2019-04-17 5:38 ` Junio C Hamano
2019-04-17 5:42 ` Taylor Blau
2019-04-17 6:14 ` Junio C Hamano
2019-04-18 6:54 ` Taylor Blau
2019-04-17 12:50 ` jc/format-patch-error-check, was " Johannes Schindelin
2019-04-18 0:48 ` Junio C Hamano
2019-04-17 12:52 ` ab/test-lib-pass-trace2-env, " Johannes Schindelin
2019-04-18 0:19 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gpaq2p.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).