From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings
Date: Sat, 25 May 2019 00:30:31 +0200 [thread overview]
Message-ID: <87a7fbfptk.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <cf0b720e-ad29-79e7-17d5-b69d50e7007e@ramsayjones.plus.com>
On Fri, May 24 2019, Ramsay Jones wrote:
> [No, I won't be sending 52 patches to the list!]
> [...]
> This series does not fix any problems or add any new features, so it
> is not important (hence the tendency to 'slip'). I don't want to
> flood the mailing list with patches that nobody wants, so: is there
> any interest in these kinds of patches? If not, I will stop now!
> (I have a 2-3 year old branch that addressed the '-Wsign-compare'
> warnings, but that is probably beyond salvaging by now :( ).
>
> This series is available from: git://repo.or.cz/git/raj.git with the
> branch name 'warn-master'. A trial merge to current 'next' and 'pu'
> branches can be found at 'warn-next' and 'warn-pu' branches. (The
> merge to 'next' went without problem, and 'pu' only required a fixup
> to the builtin/commit patch).
> [...]
> What do you think?
I think just send it to the list. We've seen worse, and it's easier to
review than needing to get out of the normal E-Mail workflow.
I'm keen on getting us to stricter compiler warnings in general, but
we'll see whether this specific thing seems worth it in review.
next prev parent reply other threads:[~2019-05-24 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 20:28 [PATCH 00/52] fix some -Wmissing-field-initializer warnings Ramsay Jones
2019-05-24 22:30 ` Ævar Arnfjörð Bjarmason [this message]
2019-05-24 23:08 ` Ramsay Jones
2019-05-30 8:47 ` Johannes Sixt
2019-05-30 12:04 ` Jeff King
2019-05-30 14:59 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7fbfptk.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).