From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id AFD001F5AE for ; Fri, 11 Jun 2021 00:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230410AbhFKBAv convert rfc822-to-8bit (ORCPT ); Thu, 10 Jun 2021 21:00:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbhFKBAv (ORCPT ); Thu, 10 Jun 2021 21:00:51 -0400 X-Greylist: delayed 1109 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Jun 2021 17:58:54 PDT Received: from mav.lukeshu.com (mav.lukeshu.com [IPv6:2001:19f0:5c00:8069:5400:ff:fe26:6a86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D27C061574 for ; Thu, 10 Jun 2021 17:58:54 -0700 (PDT) Received: from lukeshu-dw-thinkpad (unknown [IPv6:2601:281:8200:42e:4e34:88ff:fe48:5521]) by mav.lukeshu.com (Postfix) with ESMTPSA id 457C180590; Thu, 10 Jun 2021 20:58:53 -0400 (EDT) Date: Thu, 10 Jun 2021 18:58:52 -0600 Message-ID: <87a6nx6wtv.wl-lukeshu@lukeshu.com> From: Luke Shumaker To: "Johannes Schindelin via GitGitGadget" Cc: git@vger.kernel.org, Luke Shumaker , Johannes Schindelin , =?ISO-8859-1?Q?=22=C6var_Arnfj?= =?ISO-8859-1?Q?=F6r=F0_Bjarmason=22?= , Felipe Contreras Subject: Re: [PATCH 0/2] Fix git subtree on Windows In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, 10 Jun 2021 03:13:29 -0600, Johannes Schindelin via GitGitGadget wrote: > This particular condition, however, was never tested on Windows, I was going to say that I do have CI set up[0] to run the subtree tests on Windows, and was going to ask for assistance in figuring out how to set up CI's Windows to match the behavior that you're seeing with Cygwin. However, upon closer inspection: Because of how run-test-slice.sh works, it wasn't actually running the subtree test on Windows. Oops. Now, that CI setup was just on my personal copies and hadn't been submitted upstream, since I wasn't sure if it was welcome[1]. I never really got a reply to that part, but but now that we've got buy-in from Ævar for running the tests in contrib/,[2] I might spend some more time on it and try to get that submitted. That is, if Felipe doesn't beat me to it[3]. [0]: https://github.com/LukeShu/git/commit/359c71be69749621125181b9d8c109baba6bf745 [1]: https://lore.kernel.org/git/20210426174525.3937858-1-lukeshu@lukeshu.com/ [2]: https://lore.kernel.org/git/87o8d0o2or.fsf@evledraar.gmail.com/ [3]: https://lore.kernel.org/git/60abe0b32dfa1_1b2092081d@natae.notmuch/#t -- Happy hacking, ~ Luke Shumaker