git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Luke Shumaker <lukeshu@lukeshu.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Luke Shumaker" <lukeshu@datawire.io>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"\"Ævar Arnfjörð Bjarmason\"" <avarab@gmail.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Subject: Re: [PATCH 0/2] Fix git subtree on Windows
Date: Thu, 10 Jun 2021 18:58:52 -0600	[thread overview]
Message-ID: <87a6nx6wtv.wl-lukeshu@lukeshu.com> (raw)
In-Reply-To: <pull.978.git.1623316412.gitgitgadget@gmail.com>

On Thu, 10 Jun 2021 03:13:29 -0600,
Johannes Schindelin via GitGitGadget wrote:
> This particular condition, however, was never tested on Windows,

I was going to say that I do have CI set up[0] to run the subtree
tests on Windows, and was going to ask for assistance in figuring out
how to set up CI's Windows to match the behavior that you're seeing
with Cygwin.

However, upon closer inspection: Because of how run-test-slice.sh
works, it wasn't actually running the subtree test on Windows.  Oops.

Now, that CI setup was just on my personal copies and hadn't been
submitted upstream, since I wasn't sure if it was welcome[1].  I never
really got a reply to that part, but but now that we've got buy-in
from Ævar for running the tests in contrib/,[2] I might spend some
more time on it and try to get that submitted.  That is, if Felipe
doesn't beat me to it[3].

[0]: https://github.com/LukeShu/git/commit/359c71be69749621125181b9d8c109baba6bf745
[1]: https://lore.kernel.org/git/20210426174525.3937858-1-lukeshu@lukeshu.com/
[2]: https://lore.kernel.org/git/87o8d0o2or.fsf@evledraar.gmail.com/
[3]: https://lore.kernel.org/git/60abe0b32dfa1_1b2092081d@natae.notmuch/#t

-- 
Happy hacking,
~ Luke Shumaker

  parent reply	other threads:[~2021-06-11  0:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  9:13 [PATCH 0/2] Fix git subtree on Windows Johannes Schindelin via GitGitGadget
2021-06-10  9:13 ` [PATCH 1/2] subtree: fix the GIT_EXEC_PATH sanity check to work " Johannes Schindelin via GitGitGadget
2021-06-11  0:40   ` Luke Shumaker
2021-06-11  1:37     ` Junio C Hamano
2021-06-11  4:31       ` Luke Shumaker
2021-06-11 10:19     ` Johannes Schindelin
2021-06-11 13:41       ` Luke Shumaker
2021-06-14 11:56         ` Johannes Schindelin
2021-06-15  2:33           ` Junio C Hamano
2021-06-15 10:56             ` Jeff King
2021-06-15 11:05               ` Bagas Sanjaya
2021-06-15 11:18                 ` Jeff King
2021-06-15 11:27                   ` Johannes Schindelin
2021-06-16  0:52               ` Junio C Hamano
2021-06-16  7:49                 ` Jeff King
2021-06-10  9:13 ` [PATCH 2/2] subtree: fix assumption about the directory separator Johannes Schindelin via GitGitGadget
2021-06-11  1:02   ` Luke Shumaker
2021-06-11 10:35     ` Johannes Schindelin
2021-06-11  0:58 ` Luke Shumaker [this message]
2021-06-11 10:30   ` [PATCH 0/2] Fix git subtree on Windows Johannes Schindelin
2021-06-11 13:46     ` Luke Shumaker
2021-06-11 15:50     ` Felipe Contreras
2021-06-12  2:58       ` Luke Shumaker
2021-06-14 12:41 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2021-06-14 12:41   ` [PATCH v2 1/2] subtree: fix the GIT_EXEC_PATH sanity check to work " Johannes Schindelin via GitGitGadget
2021-06-15  2:37     ` Junio C Hamano
2021-06-14 12:41   ` [PATCH v2 2/2] subtree: fix assumption about the directory separator Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6nx6wtv.wl-lukeshu@lukeshu.com \
    --to=lukeshu@lukeshu.com \
    --cc=avarab@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=lukeshu@datawire.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).