git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Cc: Jeff Hostetler <git@jeffhostetler.com>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>,
	Josh Steadmon <steadmon@google.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: I made a flame graph renderer for git's trace2 output
Date: Fri, 10 May 2019 12:38:52 -0400	[thread overview]
Message-ID: <8794fd2e-6256-3238-6d87-2e726d4a91fa@gmail.com> (raw)
In-Reply-To: <87zhnuwdkp.fsf@evledraar.gmail.com>

On 5/10/2019 11:09 AM, Ævar Arnfjörð Bjarmason wrote:
> Here's a flamegraph of where git's test suite spends its time on my box:
> https://vm.nix.is/~avar/noindex/git-tests.svg
> 
> I hacked up a script for this today to plot trace2 production data, as
> noted there it's at:
> https://github.com/avar/FlameGraph/tree/stackcollapse-git-tr2-event
> 
> What are flamegraphs? See http://www.brendangregg.com/flamegraphs.html
> 
> As noted in TODOs in the script there's various stuff I'd like to do
> better, and this also shows how we need a lot more trace regions to get
> granular data.
> 
> But it's already quite cool, and I'll keep improving it. I'll submit a
> PR to Brendan's parent repo once I'm happy enough with it, I figure it
> makes more sense there than in git.git, but maybe we'd eventually want
> to teach the test suite to optionally use something like this.

This is a neat idea. Thanks!

For anyone else giving this a try, here are the steps I took to create
my own [1], much smaller test:

# run some tests
export GIT_TR2_EVENT=~/git-tr2-event.txt
git fetch --all
git gc
git push

# get the FlameGraph repo
git clone https://github.com/avar/FlameGraph.git
cd FlameGraph

(
    # Get the proper perl packages, if you don't have them
    sudo apt install cpanminus
    sudo cpanm install JSON::XS
)

./stackcollapse-git-tr2-event.pl ~/git-tr2-event.txt | ./flamegraph.pl >git-test.svg


[1] https://github.com/derrickstolee/FlameGraph/blob/git-test/git-test.svg

  reply	other threads:[~2019-05-10 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 15:09 Ævar Arnfjörð Bjarmason
2019-05-10 16:38 ` Derrick Stolee [this message]
2019-05-10 17:00   ` SZEDER Gábor
2019-05-20 18:49     ` Jeff Hostetler
2019-05-10 21:03 ` Jeff King
2019-05-10 21:57   ` Ævar Arnfjörð Bjarmason
2019-05-20 18:22     ` Jeff Hostetler
2019-05-21 14:19       ` Ævar Arnfjörð Bjarmason
2019-05-21 20:46         ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8794fd2e-6256-3238-6d87-2e726d4a91fa@gmail.com \
    --to=stolee@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).