From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2018, #04; Wed, 31)
Date: Fri, 02 Feb 2018 20:29:32 +0100 [thread overview]
Message-ID: <878tcbmbqb.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq8tcbqnbr.fsf@gitster-ct.c.googlers.com>
On Fri, Feb 02 2018, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Thu, Feb 01 2018, Junio C. Hamano jotted:
>>
>>> * nd/fix-untracked-cache-invalidation (2018-01-24) 5 commits
>>> - dir.c: stop ignoring opendir() error in open_cached_dir()
>>> - update-index doc: note a fixed bug in the untracked cache
>>> - dir.c: fix missing dir invalidation in untracked code
>>> - dir.c: avoid stat() in valid_cached_dir()
>>> - status: add a failing test showing a core.untrackedCache bug
>>>
>>> Some bugs around "untracked cache" feature have been fixed.
>>>
>>> Will merge to 'next'.
>>
>> The "update-index doc: note a fixed bug in the untracked cache" needs to
>> be amended so it doesn't say "Before 2.16, ":
>
> True; we could just say "earlier", but I am inclined to suggest that
> we get drop it altogether. Description of historical bugs is of no
> interest with the version that already fixes them, so the _only_
> value the doc update adds is to tell readers that the untracked
> cache feature is still not well proven, and core.untrackedCache may
> serve as an escape hatch from its bugs by disabling the mechanism
> added for the feature. I am *not* opposed to a replacement of the
> patch that just says something like "This feature has been cause of
> bugs even in recent versions of Git, and you may want to disable it
> as a workaround when you are hit by an otherwise undiscovered bug in
> this area", though.
- It's my experience that most users today who aren't *nix graybeards
don't use the documentation shipped on their system as their primary
source for docs.
They go to Google and might find the manpage there. Thus this
documentation will be read by users on pre-2.17 (or whenever this bug
fix gets included).
- This is very useful information if you're deploying
core.untrackedCache across a site with differing git versions. Just
because you have 2.17 doesn't mean everywhere you're about to deploy
core.untrackedCache does.
- In general I agree that we shouldn't be documenting old bugs, but I
think in this case it makes sense since the bug's really bad. Without
thinking to disable core.untrackedCache there's seemingly no way to
fix it without wiping away the index, which might lose you work.
next prev parent reply other threads:[~2018-02-02 19:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 0:56 What's cooking in git.git (Jan 2018, #04; Wed, 31) Junio C Hamano
2018-02-01 11:05 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:09 ` Junio C Hamano
2018-02-09 17:06 ` Johannes Schindelin
2018-02-09 18:30 ` Ævar Arnfjörð Bjarmason
2018-02-01 12:11 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:05 ` Junio C Hamano
2018-02-02 19:29 ` Ævar Arnfjörð Bjarmason [this message]
2018-02-09 18:37 ` Ævar Arnfjörð Bjarmason
2018-02-09 18:54 ` Junio C Hamano
2018-02-09 21:04 ` [PATCH 0/2] update-index doc: note new caveats in 2.17 Ævar Arnfjörð Bjarmason
2018-02-09 21:40 ` Junio C Hamano
2018-02-09 22:10 ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04 ` [PATCH 1/2] update-index doc: note a fixed bug in the untracked cache Ævar Arnfjörð Bjarmason
2018-02-09 21:52 ` Junio C Hamano
2018-02-09 22:14 ` Ævar Arnfjörð Bjarmason
2018-02-09 22:50 ` Junio C Hamano
2018-02-09 22:58 ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04 ` [PATCH 2/2] update-index doc: note the caveat with "could not open..." Ævar Arnfjörð Bjarmason
2018-02-10 10:09 ` What's cooking in git.git (Jan 2018, #04; Wed, 31) Duy Nguyen
2018-02-11 14:44 ` Ævar Arnfjörð Bjarmason
2018-02-12 10:04 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tcbmbqb.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).