From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id ECB9F1F8C6 for ; Thu, 24 Jun 2021 23:42:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232876AbhFXXpH (ORCPT ); Thu, 24 Jun 2021 19:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhFXXpG (ORCPT ); Thu, 24 Jun 2021 19:45:06 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2313C061756 for ; Thu, 24 Jun 2021 16:42:45 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id s15so10921616edt.13 for ; Thu, 24 Jun 2021 16:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=ACd6SSVF3/VXiW/wueWgelcMR3a2bzP+T+ZlVuHmNAc=; b=d1jopbKEJLH4c+F//n2d75VTIcB1jRd6QtwYR/sTtKrdAqfCT1DboKbNTa4vkRTw/X kKsirV6I6YXculzFqhCKIov5jXaYVcMpiDY/PJ6YUU2fti6ha7tIKrt9pfAqjwXXfjVC P3G5mC1VeLkCaHx85+sO6KG1yfl7D54tjyq51nKATcYIyWpBDaNndE5bsAh95ZOkezmL ij/ozV8YARbo2d/QQ2HLoxGWINE5olzu5k2a2eH+aUmz3ZNZCIyAJThCVo5I/Hn+ddIm niIw/97NbcRrnUvaWIf5g4Xt2PesB4b+ik0rge260HFh5ALv4bRvw0zuRpXm4864AfCK Q45Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=ACd6SSVF3/VXiW/wueWgelcMR3a2bzP+T+ZlVuHmNAc=; b=IRSU5noeSxbSn5V08eSBePQjLSSy9KensNxoy83BwnBcBvfWlNx1JKx9A5ja5jyPKh 6j3kFKhi+/t5Edcl9GjvEGoV8dN2U4BBufLVLk5+3JKMiw50UhyG9Oi2NyGVVMnvjlvQ G6ncRGvteoTWDj2v1Kq2NJ+mQTRHwzPHBwHgiFOZVh35sv4SPAvMBAVMTCE1KuVE/7Yt 8NZmfCjA9YS8F6OlRxFCyjbdDU8ojoq4keEfpLcmItQxM0pkuiERhipu9tM+pilcbb8J VjOvFk9KvV0HoRSbV5wXp55SpqMmghzv8axWONzgF7pGUMp6fP70Q/8o3gYPfX+R+Nc8 fHdw== X-Gm-Message-State: AOAM530x/g+kJG6vM/PfcVhDV/S+s5N3xThf9anfmIOzXLcCtwHt8gFR fZNNDIUXF0CMr2PwnoqW8aM= X-Google-Smtp-Source: ABdhPJyNNNQPeod38J4BAzViIZe3Mpj8spGRu/3cCr3mP3iNM6LlkS4RG3u+edlQHPvKbCgt4GkWNA== X-Received: by 2002:aa7:c997:: with SMTP id c23mr10736668edt.42.1624578163135; Thu, 24 Jun 2021 16:42:43 -0700 (PDT) Received: from evledraar (j57224.upc-j.chello.nl. [24.132.57.224]) by smtp.gmail.com with ESMTPSA id aq12sm1802902ejc.77.2021.06.24.16.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 16:42:42 -0700 (PDT) From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Taylor Blau Cc: git@vger.kernel.org, peff@peff.net, dstolee@microsoft.com, gitster@pobox.com, jonathantanmy@google.com Subject: Re: [PATCH v2 06/24] midx: make a number of functions non-static Date: Fri, 25 Jun 2021 01:42:06 +0200 References: User-agent: Debian GNU/Linux 11 (bullseye); Emacs 27.1; mu4e 1.5.12 In-reply-to: Message-ID: <878s2yzv65.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jun 21 2021, Taylor Blau wrote: > These functions will be called from outside of midx.c in a subsequent > patch. So "a number" is "two" and "a subsequent patch" appears to be 13/24. I think this would be clearer just squashed into whatever needs it, or at least if it comes right before the new use in the series.