From: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> To: Dan Jacques <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support Date: Mon, 08 Jan 2018 23:16:08 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Jan 08 2018, Dan Jacques jotted: > On 2018-01-08 20:27, Johannes Schindelin wrote: > >> > Maybe we covered this in previous submissions, but refresh my memory, >> > why is the *_PERL define still needed? Reading this explanation doesn't >> > make sense to me, but I'm probably missing something. >> >> If the reason is to accommodate Windows, I think it'd make more sense to >> change the way Git for Windows handles this, and use the same relative >> paths (if possible, that is, see the GITPERLLIB problems I mentioned >> elsewhere and which necessitated >> https://github.com/git-for-windows/git/commit/3b2f716bd8). >> (...) >> What do you think? Should we just fold the RUNTIME_PREFIX_PERL handling >> into RUNTIME_PREFIX and be done with that part? >> (...) >> As I mentioned in the mail I just finished and sent (I started it hours >> ago, but then got busy with other things while the builds were running): I >> am totally cool with changing this on Windows, too. Should simplify >> things, right? > > No objections here. I see it as adding slightly more risk to this patch's > potential impact on Windows builds, but if Git-for-Windows is okay with that, > I'll go ahead and fold RUNTIME_PREFIX_PERL into RUNTIME_PREFIX for > simplicity's sake. > > I'll add a "NO_RUNTIME_PREFIX_PERL" flag as per avarab@'s suggestion as a > potential mitigation if a problem does end up arising in Windows builds, > with a note that NO_RUNTIME_PREFIX_PERL can be deleted if everything seems > to be working. What do you think? To be clear, I meant that if it's determined by you/others that an opt-out on Windows is needed I think it makes sense to make it a NO_* flag, but if there's a solution where we can just turn it on for everything then ideally we'd just have RUNTIME_PREFIX=YesPlease.
next prev parent reply other threads:[~2018-01-08 22:16 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-08 3:02 [PATCH v5 0/3] RUNTIME_PREFIX relocatable Git Dan Jacques 2018-01-08 3:02 ` [PATCH v5 1/3] Makefile: generate Perl header from template file Dan Jacques 2018-01-08 3:02 ` [PATCH v5 2/3] Makefile: add Perl runtime prefix support Dan Jacques 2018-01-08 9:41 ` Ævar Arnfjörð Bjarmason 2018-01-08 19:18 ` Dan Jacques 2018-01-08 20:00 ` Ævar Arnfjörð Bjarmason 2018-01-08 20:27 ` Johannes Schindelin 2018-01-08 21:54 ` Junio C Hamano 2018-01-08 22:05 ` Dan Jacques 2018-01-08 22:16 ` Ævar Arnfjörð Bjarmason [this message] 2018-01-08 22:18 ` Dan Jacques 2018-01-08 20:24 ` Johannes Schindelin 2018-01-08 3:02 ` [PATCH v5 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems Dan Jacques
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git